Fix 03210_variant_with_aggregate_function_type test#74012
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Jan 1, 2025
Merged
Fix 03210_variant_with_aggregate_function_type test#74012alexey-milovidov merged 1 commit intoClickHouse:masterfrom
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
ianton-ru
commented
Dec 31, 2024
| ) ENGINE = MergeTree ORDER BY (); | ||
|
|
||
| INSERT INTO source SELECT ['fail', 'success'][number % 2] as Name, number AS Value FROM numbers(1000); | ||
| INSERT INTO source SELECT ['fail', 'success'][((number + 1) % 2) + 1] as Name, number AS Value FROM numbers(1000); |
Contributor
Author
There was a problem hiding this comment.
Just small fix - arrow index starts from 1, not from 0, so value 'success' was not used before.
ianton-ru
commented
Dec 31, 2024
| FROM test_agg_variant | ||
| GROUP BY Name; | ||
| GROUP BY Name | ||
| ORDER BY Name; |
Contributor
Author
There was a problem hiding this comment.
Sometimes test failed with reversed rows order in responce.
alexey-milovidov
approved these changes
Dec 31, 2024
Contributor
|
This is an automated comment for commit 4fe59f3 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix stability for test 03210_variant_with_aggregate_function_type
Documentation entry for user-facing changes
Test was failed if request returned rows in different order. "ORDER BY" should fix it.
CI Settings (Only check the boxes if you know what you are doing)
All builds in Builds_1 and Builds_2 stages are always mandatory
and will run independently of the checks below: