Skip to content

Use Analyzer in PrometheusRemoteReadProtocol#75729

Merged
novikd merged 2 commits intomasterfrom
analyzer-prometheus
Feb 14, 2025
Merged

Use Analyzer in PrometheusRemoteReadProtocol#75729
novikd merged 2 commits intomasterfrom
analyzer-prometheus

Conversation

@novikd
Copy link
Copy Markdown
Member

@novikd novikd commented Feb 7, 2025

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Use Analyzer in PrometheusRemoteReadProtocol.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Feb 7, 2025

Workflow [PR], commit [6f3bbe8]

@clickhouse-gh clickhouse-gh Bot added the pr-improvement Pull request with some product improvements label Feb 7, 2025
@nikitamikhaylov nikitamikhaylov self-assigned this Feb 7, 2025
Comment on lines +478 to +479
InterpreterSelectQueryAnalyzer interpreter(select_query, context, SelectQueryOptions{});
io = interpreter.execute();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just make this the default option regardless of the setting.

@novikd
Copy link
Copy Markdown
Member Author

novikd commented Feb 10, 2025

Integration tests (asan, old analyzer, 5/6) — fail: 1, passed: 532

Unrelated

@novikd novikd enabled auto-merge February 10, 2025 09:24
@novikd novikd added this pull request to the merge queue Feb 14, 2025
Merged via the queue into master with commit 7a1fb40 Feb 14, 2025
@novikd novikd deleted the analyzer-prometheus branch February 14, 2025 18:17
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants