Speed up 10x test_storage_rabbitmq::test_failed_connection#79217
Merged
Speed up 10x test_storage_rabbitmq::test_failed_connection#79217
Conversation
Tune the numbers to get the same behavior but with much less work done. This is not an stress test, so it's still good if we use 1000 messages instead of several thousands as long as we test the same thing.
Contributor
52bb0e8 to
e502595
Compare
This reverts commit e502595.
kssenii
reviewed
Apr 15, 2025
a0ab240 to
3df7dbb
Compare
kssenii
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first thing I should've done to make my life easier when testing it. Now that I have grasped better what the test does, I can do it in confidence:
Tune the numbers to get the same behavior but with much less work done. This is not an stress test, so it's still good if we use 100 messages instead of several thousands as long as we test the same thing.
Before
After
Also, the RabitMQMonitor seems not very consistent according to some false positive reports such as https://s3.amazonaws.com/clickhouse-test-reports/PRs/79212/460d6f15bdb3b12c485c171a7e13c9bb7955e4a6//integration_tests_asan_old_analyzer_1_6/integration_run_test_storage_rabbitmq_test_failed_connection_py_0.log
We're getting this, even though all messages were consumed ok in ClickHouse:
Thus, let's make it a warning log instead of a hard failure for now
Related to #71049
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes