Add error_message for deduplicated parts in system.part_log#80264
Add error_message for deduplicated parts in system.part_log#80264yariks5s merged 2 commits intoClickHouse:masterfrom
Conversation
|
I propose to check this new logic with an integration test because I have concerns about this check, and I'm sure that this check you've added will eventually become broken/flaky in case we have an extensive testing process, and current test will be at the end of the testing queue, it already happens sometimes: This is because we may have allocated a lot of logging entries in the table, and then we're unable to execute the query due to the CI restrictions. Checking this simple logic with an integration test can solve this problem. |
It should be OK I think, the mentioned failure was caused by a different issue (besides we already have similar tests) Also we need to add some changes for SMT likely |
d9befc4 to
cb61057
Compare
|
@yariks5s could we please continue this PR? |
|
For me, it looks okay, maybe @azat has something to point out |
|
Looks good, but the private should be adjusted as well |
|
Dear @yariks5s, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself. |
|
Dear @yariks5s, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself. |
|
@yariks5s don't you mind to continue? |
cb61057 to
87f98ad
Compare
|
Workflow [PR], commit [8fb6932] Summary: ❌
|
|
@yariks5s Hey! just a friendly reminder about this PR |
|
@AVMusorin could you please update with master? I've fixed the problem on our side |
…plica Fixes: ``` Code: 158. DB::Exception: Limit for rows (controlled by 'max_rows_to_read' setting) exceeded, max rows: 20.00 million, current rows: 134.60 million. (TOO_MANY_ROWS) (version 25.4.1.36938 (official build)) (from [::1]:60320) (comment: 02124_insert_deduplication_token_replica.sql) ``` Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
87f98ad to
8fb6932
Compare
should be fixed in #91328 |
|
b15c6d2
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add error message that the part was deduplicated
Documentation entry for user-facing changes