Fix build of mysqlxx_pool_test#82167
Conversation
clickhouse-gh
bot
added
the
pr-not-for-changelog
|
I wonder why this executable was not build in CI when I opened a PR for my changes. |
Previously only clickhouse-bundle was build for almost all builds, except for tidy, but tidy uses dummy linker, that's why we cannot rely on it.
Indeed. Will be fixed here 3e25692 |
| @@ -1,2 +1,2 @@ | |||
| clickhouse_add_executable (mysqlxx_pool_test mysqlxx_pool_test.cpp) | |||
| target_link_libraries (mysqlxx_pool_test PRIVATE mysqlxx dbms clickhouse_common_config loggers_no_text_log) | |||
| target_link_libraries (mysqlxx_pool_test PRIVATE mysqlxx clickhouse_common_config loggers_no_text_log) | |||
There was a problem hiding this comment.
SO finally dbms is not needed? Not even the 02443_detach_attach_partition?
There was a problem hiding this comment.
For this target - yes, not sure that I got part about 02443_detach_attach_partition
robot-ch-test-poll2
added
the
pr-synced-to-cloud
| elif build_type == BuildTypes.AMD_DEBUG: | ||
| targets = "-k0 all" |
There was a problem hiding this comment.
This is completely ignored because amd_debug is within the BUILD_TYPE_TO_DEB_PACKAGE_TYPE dict.
We can check in the log of this same PR that it didn't work: https://s3.amazonaws.com/clickhouse-test-reports/PRs/82167/3e25692c37fbf9e4fdd922cee43c3b538cfc61d7//build_amd_debug/job.log
> Start execution for [Build ClickHouse]
Run command: [ninja clickhouse-bundle]
If we want AMD_DEBUG to build all targets, we should move the if statement prior to the if build_type in BUILD_TYPE_TO_DEB_PACKAGE_TYPE
There was a problem hiding this comment.
Hi @pamarcos
I don't know is we want to build on amd, but in any case please open a new issue referencing this (or reopen this one, as you prefer)
There was a problem hiding this comment.
If we want AMD_DEBUG to build all targets, we should move the if statement prior to the if build_type in BUILD_TYPE_TO_DEB_PACKAGE_TYPE
Sigh, thanks for noticing, it looks error prone to check first this set and only after exceptions, anyway fix is here - #82723
5 participants
Changelog category (leave one):
Previously due to
dbmsit requiresclickhouse_functions_text, but it does not needdbmsat all.Follow-up: for #80641