ci: fix waiting for queries in stress check#82562
Merged
azat merged 1 commit intoClickHouse:masterfrom Jun 25, 2025
Merged
Conversation
Contributor
|
Workflow [PR], commit [0ac3781] Summary: ❌
|
Right now it always fails with timeout:
Received exception from server (version 25.7.1):
Code: 159. DB::Exception: Received from localhost:9000. DB::Exception: Timeout exceeded: elapsed 60033.770956 ms, maximum: 60000 ms. (TIMEOUT_EXCEEDED)
(query: SELECT sleepEachRow((
SELECT maxOrDefault(300 - elapsed) + 1
FROM system.processes
WHERE query NOT LIKE '%FROM system.processes%' AND elapsed < 300
) / 300)
FROM numbers(300)
FORMAT Null
SETTINGS function_sleep_max_microseconds_per_block = 0
)
Rewrite it to sleep only until there are some queries
d38c9d6 to
0ac3781
Compare
Algunenano
reviewed
Jun 25, 2025
Member
Algunenano
left a comment
There was a problem hiding this comment.
Any idea why we don't KILL all queries before waiting? It'd be faster in most cases (and when it doesn't it's a misbehaviour)
Member
Author
No clue, but if it works now w/o hanged queries, then it make sense to preserve to make sure that all queries can be finished even after stressing |
Member
Author
|
Algunenano
approved these changes
Jun 25, 2025
Merged
via the queue into
ClickHouse:master
with commit Jun 25, 2025
24b5ead
119 of 122 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now it always fails with timeout:
Rewrite it to sleep only until there are some queries
CI: https://s3.amazonaws.com/clickhouse-test-reports/json.html?
PR=82364&sha=latest&name_0=PR&name_1=Stress+test+%28amd_debug%29
Changelog category (leave one):