fix tcp connection polls, reconnect broken connections#83059
Merged
Conversation
Contributor
clickhouse-gh
Bot
added
the
pr-not-for-changelog
CheSema
changed the title
Avogar
approved these changes
Jul 2, 2025
CheSema
force-pushed
the
chesema-fix-connection-pools
branch
from
37ea906 to
e9fc989
Compare
Avogar
approved these changes
Jul 2, 2025
robot-ch-test-poll3
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectionPoolWithFailover doing bad thing. It holds connection in whatever state. Broken connections are being put back to the pool at the end and they are stored there as well.
More global fix than #83056
Related to:
It is not allowed to use read buffer after it thrown an exceptoin.
#81951
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes