Skip to content

Limit column to be defined only once for the text index#83303

Merged
rschu1ze merged 6 commits intomasterfrom
ahmadov/text-index-column
Jul 6, 2025
Merged

Limit column to be defined only once for the text index#83303
rschu1ze merged 6 commits intomasterfrom
ahmadov/text-index-column

Conversation

@ahmadov
Copy link
Copy Markdown
Member

@ahmadov ahmadov commented Jul 4, 2025

Closes #82385

Changelog category (leave one):

  • Experimental Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Recently, fuzzer found an issue for the searchAny and searchAll functions (see #82385).
This exception occurs whenever searchAny or searchAll functions get different text index parameters for the same column.
This scenario is only possible when there are two different text indices for the same column. This PR limits a column to be defined only once for the text index, but wrapper around the column (e.g. lower(column)) is still allowed.

Also, re-enable searchAny and searchAll functions.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Jul 4, 2025

Workflow [PR], commit [b92a4e5]

Summary:

job_name test_name status info comment
Stateless tests (amd_tsan, s3 storage, 3/3) failure
Start ClickHouse Server failure
Stateless tests (amd_coverage,2/6) failure
03221_insert_timeout_overflow_mode FAIL
Stress test (amd_debug) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL

@clickhouse-gh clickhouse-gh Bot added the pr-experimental Experimental Feature label Jul 4, 2025
@ahmadov ahmadov requested review from Ergus and rschu1ze July 4, 2025 18:54
@Ergus
Copy link
Copy Markdown
Member

Ergus commented Jul 4, 2025

I also wanted the same the other way around. So, ensure that a column only has one index. Because right now it is not deterministic which index will be used

@ahmadov ahmadov changed the title Limit column to be define only once for the text index Limit column to be defined only once for the text index Jul 4, 2025
@rschu1ze
Copy link
Copy Markdown
Member

rschu1ze commented Jul 6, 2025

Stateless tests (amd_tsan, s3 storage, 3/3)

Started setup_minio.sh asynchronously with PID 1306
Run command: [/mc ls clickminio/test | grep -q .]
mc: <ERROR> Unable to list folder. Requested path `/home/ubuntu/actions-runner/_work/ClickHouse/ClickHouse/clickminio` not found
ERROR: command failed, exit code: 1, retry: 0/1
  • Infra issue?

Stateless tests (amd_coverage,2/6)

Stress test (amd_debug)

@rschu1ze rschu1ze added this pull request to the merge queue Jul 6, 2025
Merged via the queue into master with commit df8d10b Jul 6, 2025
117 of 124 checks passed
@rschu1ze rschu1ze deleted the ahmadov/text-index-column branch July 6, 2025 16:13
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-experimental Experimental Feature pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logical error: 'Function 'searchAll': Different index parameters are set.'

4 participants