Skip to content

Add access check to GCS function#83503

Merged
pufit merged 1 commit intomasterfrom
pufit/fix-gcs-access
Jul 19, 2025
Merged

Add access check to GCS function#83503
pufit merged 1 commit intomasterfrom
pufit/fix-gcs-access

Conversation

@pufit
Copy link
Copy Markdown
Member

@pufit pufit commented Jul 9, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Historically, gcs function did not require any access to use. Now it will check GRANT READ ON S3 permission for usage.
Closes #70567

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 9, 2025 •
edited
Loading

Workflow [PR], commit [dff4f7a]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, 2/2) failure
Logical error thrown (see clickhouse-server.log or logical_errors.txt) FAIL

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jul 9, 2025
@nikitamikhaylov nikitamikhaylov added the pr-backward-incompatible Pull request with backwards incompatible changes label Jul 9, 2025
@antaljanosbenjamin antaljanosbenjamin self-assigned this Jul 10, 2025
@nikitamikhaylov
Copy link
Copy Markdown
Member

nikitamikhaylov commented Jul 10, 2025

@antaljanosbenjamin Please review.

antaljanosbenjamin
antaljanosbenjamin approved these changes Jul 10, 2025
View reviewed changes
@nikitamikhaylov
Copy link
Copy Markdown
Member

nikitamikhaylov commented Jul 16, 2025

@pufit @antaljanosbenjamin Let's merge?

@pufit
Copy link
Copy Markdown
Member Author

pufit commented Jul 19, 2025

Statless tests: #74734

@pufit pufit added this pull request to the merge queue Jul 19, 2025
Merged via the queue into master with commit 470c2f0 Jul 19, 2025
119 of 122 checks passed
@pufit pufit deleted the pufit/fix-gcs-access branch July 19, 2025 02:40
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antaljanosbenjamin antaljanosbenjamin antaljanosbenjamin approved these changes

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@antaljanosbenjamin antaljanosbenjamin

Labels

pr-backward-incompatible Pull request with backwards incompatible changes pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gcs table function requires fewer permissions than s3

4 participants

@pufit @nikitamikhaylov @antaljanosbenjamin @robot-ch-test-poll3