Hide avro schema registry auth in logs#83713
Merged
antaljanosbenjamin merged 2 commits intomasterfrom Jul 21, 2025
Merged
Conversation
Contributor
|
Workflow [PR], commit [6727e26] Summary: ⏳
|
Comment on lines
+209
to
+211
| CustomType custom; | ||
| if (change.value.tryGet<CustomType>(custom) && custom.isSecret()) | ||
| return true; |
Member
Author
There was a problem hiding this comment.
@kssenii I am not too confident with these changes, but I think my changes actually improve the code and shouldn't break anytihng.
kssenii
approved these changes
Jul 16, 2025
Member
Author
|
Member
Author
|
Marking the checks successful manually. |
This was referenced Jul 21, 2025
robot-ch-test-poll3
added a commit
that referenced
this pull request
Jul 21, 2025
Cherry pick #83713 to 25.4: Hide avro schema registry auth in logs
robot-clickhouse
added a commit
that referenced
this pull request
Jul 21, 2025
This was referenced Jul 21, 2025
robot-ch-test-poll3
added a commit
that referenced
this pull request
Jul 21, 2025
Cherry pick #83713 to 25.5: Hide avro schema registry auth in logs
robot-clickhouse
added a commit
that referenced
this pull request
Jul 21, 2025
This was referenced Jul 21, 2025
robot-ch-test-poll3
added a commit
that referenced
this pull request
Jul 21, 2025
Cherry pick #83713 to 25.6: Hide avro schema registry auth in logs
robot-clickhouse
added a commit
that referenced
this pull request
Jul 21, 2025
This was referenced Jul 21, 2025
robot-ch-test-poll3
added a commit
that referenced
this pull request
Jul 21, 2025
Cherry pick #83713 to 25.7: Hide avro schema registry auth in logs
robot-clickhouse
added a commit
that referenced
this pull request
Jul 21, 2025
robot-clickhouse-ci-1
added a commit
that referenced
this pull request
Jul 21, 2025
Cherry pick #83713 to 25.3: Hide avro schema registry auth in logs
robot-clickhouse
added a commit
that referenced
this pull request
Jul 21, 2025
clickhouse-gh bot
added a commit
that referenced
this pull request
Jul 21, 2025
Backport #83713 to 25.6: Hide avro schema registry auth in logs
clickhouse-gh bot
added a commit
that referenced
this pull request
Jul 21, 2025
Backport #83713 to 25.7: Hide avro schema registry auth in logs
antaljanosbenjamin
added a commit
that referenced
this pull request
Jul 21, 2025
Backport #83713 to 25.5: Hide avro schema registry auth in logs
antaljanosbenjamin
added a commit
that referenced
this pull request
Jul 22, 2025
Backport #83713 to 25.3: Hide avro schema registry auth in logs
antaljanosbenjamin
added a commit
that referenced
this pull request
Jul 22, 2025
Backport #83713 to 25.4: Hide avro schema registry auth in logs
antaljanosbenjamin
added a commit
that referenced
this pull request
Jul 22, 2025
antaljanosbenjamin
added a commit
that referenced
this pull request
Jul 22, 2025
…83713 Revert "Backport #83713 to 25.3: Hide avro schema registry auth in logs"
antaljanosbenjamin
added a commit
that referenced
this pull request
Jul 22, 2025
antaljanosbenjamin
added a commit
that referenced
this pull request
Jul 23, 2025
…ackport/25.3/83713 Revert "Revert "Backport #83713 to 25.3: Hide avro schema registry auth in logs""
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Mask Avro schema registry authentication details to be not visible to user or in logs.
Documentation entry for user-facing changes