Skip to content

Hide avro schema registry auth in logs#83713

Merged
antaljanosbenjamin merged 2 commits intomasterfrom
hide-avro-schema-registry-auth-in-logs
Jul 21, 2025
Merged

Hide avro schema registry auth in logs#83713
antaljanosbenjamin merged 2 commits intomasterfrom
hide-avro-schema-registry-auth-in-logs

Conversation

@antaljanosbenjamin
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Mask Avro schema registry authentication details to be not visible to user or in logs.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 14, 2025

Workflow [PR], commit [6727e26]

Summary:

job_name test_name status info comment
Stress test (arm_asan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Cannot start clickhouse-server FAIL
Server failed to start (see application_errors.txt and clickhouse-server.clean.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jul 14, 2025
Comment on lines +209 to +211
CustomType custom;
if (change.value.tryGet<CustomType>(custom) && custom.isSecret())
return true;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kssenii I am not too confident with these changes, but I think my changes actually improve the code and shouldn't break anytihng.

@kssenii kssenii self-assigned this Jul 14, 2025
@antaljanosbenjamin
Copy link
Copy Markdown
Member Author

@antaljanosbenjamin
Copy link
Copy Markdown
Member Author

Marking the checks successful manually.

@antaljanosbenjamin antaljanosbenjamin added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jul 21, 2025
@antaljanosbenjamin antaljanosbenjamin added this pull request to the merge queue Jul 21, 2025
Merged via the queue into master with commit a4cb645 Jul 21, 2025
230 of 241 checks passed
@antaljanosbenjamin antaljanosbenjamin deleted the hide-avro-schema-registry-auth-in-logs branch July 21, 2025 10:09
robot-ch-test-poll3 added a commit that referenced this pull request Jul 21, 2025
Cherry pick #83713 to 25.4: Hide avro schema registry auth in logs
robot-ch-test-poll3 added a commit that referenced this pull request Jul 21, 2025
Cherry pick #83713 to 25.5: Hide avro schema registry auth in logs
robot-ch-test-poll3 added a commit that referenced this pull request Jul 21, 2025
Cherry pick #83713 to 25.6: Hide avro schema registry auth in logs
robot-ch-test-poll3 added a commit that referenced this pull request Jul 21, 2025
Cherry pick #83713 to 25.7: Hide avro schema registry auth in logs
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Jul 21, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 21, 2025
robot-clickhouse-ci-1 added a commit that referenced this pull request Jul 21, 2025
Cherry pick #83713 to 25.3: Hide avro schema registry auth in logs
clickhouse-gh bot added a commit that referenced this pull request Jul 21, 2025
Backport #83713 to 25.6: Hide avro schema registry auth in logs
clickhouse-gh bot added a commit that referenced this pull request Jul 21, 2025
Backport #83713 to 25.7: Hide avro schema registry auth in logs
antaljanosbenjamin added a commit that referenced this pull request Jul 21, 2025
Backport #83713 to 25.5: Hide avro schema registry auth in logs
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 21, 2025
antaljanosbenjamin added a commit that referenced this pull request Jul 22, 2025
Backport #83713 to 25.3: Hide avro schema registry auth in logs
antaljanosbenjamin added a commit that referenced this pull request Jul 22, 2025
Backport #83713 to 25.4: Hide avro schema registry auth in logs
antaljanosbenjamin added a commit that referenced this pull request Jul 22, 2025
…83713

Revert "Backport #83713 to 25.3: Hide avro schema registry auth in logs"
antaljanosbenjamin added a commit that referenced this pull request Jul 23, 2025
…ackport/25.3/83713

Revert "Revert "Backport #83713 to 25.3: Hide avro schema registry auth in logs""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants