Skip to content

Fix implicit indexes breaking Replicated Database#83751

Merged
evillique merged 1 commit intoClickHouse:masterfrom
evillique:implicit-indexes-rdb
Jul 17, 2025
Merged

Fix implicit indexes breaking Replicated Database#83751
evillique merged 1 commit intoClickHouse:masterfrom
evillique:implicit-indexes-rdb

Conversation

@evillique
Copy link
Copy Markdown
Member

@evillique evillique commented Jul 15, 2025 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix the issue where, if a MergeTree table is created with add_minmax_index_for_numeric_columns=1 or add_minmax_index_for_string_columns=1, the index is later materialized during an ALTER operation, and it prevents the Replicated database from initializing correctly on a new replica.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 15, 2025 •
edited
Loading

Workflow [PR], commit [fa70a55]

Summary: ❌

job_name test_name status info comment
Integration tests (release, 3/4) failure
Job Timeout Expired FAIL

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jul 15, 2025
@evillique evillique added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jul 15, 2025
@SmitaRKulkarni SmitaRKulkarni self-assigned this Jul 15, 2025
@evillique evillique requested a review from SmitaRKulkarni July 17, 2025 13:07
SmitaRKulkarni
SmitaRKulkarni approved these changes Jul 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SmitaRKulkarni SmitaRKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evillique evillique added this pull request to the merge queue Jul 17, 2025
Merged via the queue into ClickHouse:master with commit 636d82a Jul 17, 2025
119 of 122 checks passed
@evillique evillique deleted the implicit-indexes-rdb branch July 17, 2025 13:59
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 17, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Jul 17, 2025
This was referenced Jul 17, 2025
Closed
Merged
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Jul 17, 2025
@robot-ch-test-poll4
Merge pull request #83912 from ClickHouse/cherrypick/25.4/83751
332c8ae 
Cherry pick #83751 to 25.4: Fix implicit indexes breaking Replicated Database
robot-clickhouse added a commit that referenced this pull request Jul 17, 2025
@robot-clickhouse
Backport #83751 to 25.4: Fix implicit indexes breaking Replicated Dat…
394eadc 
…abase
This was referenced Jul 17, 2025
Merged
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Jul 17, 2025
@robot-ch-test-poll4
Merge pull request #83914 from ClickHouse/cherrypick/25.5/83751
18e3c17 
Cherry pick #83751 to 25.5: Fix implicit indexes breaking Replicated Database
robot-clickhouse added a commit that referenced this pull request Jul 17, 2025
@robot-clickhouse
Backport #83751 to 25.5: Fix implicit indexes breaking Replicated Dat…
84f81d0 
…abase
This was referenced Jul 17, 2025
Merged
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Jul 17, 2025
@robot-ch-test-poll4
Merge pull request #83916 from ClickHouse/cherrypick/25.6/83751
7e7bc72 
Cherry pick #83751 to 25.6: Fix implicit indexes breaking Replicated Database
robot-clickhouse added a commit that referenced this pull request Jul 17, 2025
@robot-clickhouse
Backport #83751 to 25.6: Fix implicit indexes breaking Replicated Dat…
b797a1f 
…abase
This was referenced Jul 17, 2025
Merged
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Jul 17, 2025
@robot-ch-test-poll4
Merge pull request #83918 from ClickHouse/cherrypick/25.7/83751
7627f0d 
Cherry pick #83751 to 25.7: Fix implicit indexes breaking Replicated Database
robot-clickhouse added a commit that referenced this pull request Jul 17, 2025
@robot-clickhouse
Backport #83751 to 25.7: Fix implicit indexes breaking Replicated Dat…
5a2c953 
…abase
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 17, 2025
Merged
clickhouse-gh bot added a commit that referenced this pull request Jul 17, 2025
@clickhouse-gh
Merge pull request #83917 from ClickHouse/backport/25.6/83751
e09965b 
Backport #83751 to 25.6: Fix implicit indexes breaking Replicated Database
clickhouse-gh bot added a commit that referenced this pull request Jul 17, 2025
@clickhouse-gh
Merge pull request #83919 from ClickHouse/backport/25.7/83751
94e4b63 
Backport #83751 to 25.7: Fix implicit indexes breaking Replicated Database
alexey-milovidov added a commit that referenced this pull request Jul 17, 2025
@alexey-milovidov
Merge pull request #83915 from ClickHouse/backport/25.5/83751
259cacf 
Backport #83751 to 25.5: Fix implicit indexes breaking Replicated Database
evillique added a commit that referenced this pull request Jul 17, 2025
@evillique
Merge pull request #83913 from ClickHouse/backport/25.4/83751
fbd8985 
Backport #83751 to 25.4: Fix implicit indexes breaking Replicated Database
robot-ch-test-poll4 added a commit that referenced this pull request Jul 17, 2025
@robot-ch-test-poll4
Merge pull request #83911 from ClickHouse/cherrypick/25.3/83751
5b79bf3 
Cherry pick #83751 to 25.3: Fix implicit indexes breaking Replicated Database
robot-clickhouse added a commit that referenced this pull request Jul 17, 2025
@robot-clickhouse
Backport #83751 to 25.3: Fix implicit indexes breaking Replicated Dat…
bc98ce8 
…abase
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 17, 2025
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 17, 2025
evillique added a commit that referenced this pull request Jul 17, 2025
@evillique
Merge pull request #83953 from ClickHouse/backport/25.3/83751
dfddf7c 
Backport #83751 to 25.3: Fix implicit indexes breaking Replicated Database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SmitaRKulkarni SmitaRKulkarni SmitaRKulkarni approved these changes

Assignees

@SmitaRKulkarni SmitaRKulkarni

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@evillique @SmitaRKulkarni @robot-ch-test-poll1 @robot-ch-test-poll3 @robot-clickhouse-ci-2