Revert "Revert "Add a test for #56334""#84143
Merged
alexey-milovidov merged 11 commits intomasterfrom Jan 26, 2026
Merged
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-not-for-changelog
…mismatch-after-metadata-only-alter
…mismatch-after-metadata-only-alter
Member
|
@alexey-milovidov |
…mismatch-after-metadata-only-alter
…mismatch-after-metadata-only-alter
…mismatch-after-metadata-only-alter
Member
|
The introduced test #56334 is still valid issue |
devcrafter
changed the title
…mismatch-after-metadata-only-alter
…mismatch-after-metadata-only-alter
…r-metadata-only-alter' of github.com:ClickHouse/ClickHouse into revert-84024-revert-84016-block-structure-mismatch-after-metadata-only-alter
…mismatch-after-metadata-only-alter
…projection optimization When using aggregate projection optimization (e.g., minmax_count projection), the projection data may have different types for key columns due to metadata-only ALTERs (e.g., extending an Enum). This caused a "Block structure mismatch" error in `AggregatingStep::requestOnlyMergeForAggregateProjection`. The fix adapts the projection input header to use the expected output types for columns that exist in the output header. This ensures that after `updateOutputHeader()` is called, the output header types match the expected types from the original query. Closes #56334 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
|
@amosbird, I'm a little bit doubtful about this. Maybe you can take a look. |
alexey-milovidov
deleted the
revert-84024-revert-84016-block-structure-mismatch-after-metadata-only-alter
branch
robot-ch-test-poll1
added
the
pr-synced-to-cloud
Collaborator
I don’t see how this relates to projections in the tests, and I cannot reproduce any failures using fiddle across all major versions since 25.8. |
Member
Author
|
@amosbird the test is intended to run on Debug, ASan, MSan, TSan, UBSan builds. |
Member
Author
It's likely about "virtual projections". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #84024
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
After metadata-only ALTERs, such as extending the elements of Enums, the optimization of aggregation with projection may end up producing an exception.