Skip to content

Fix crash during lighweight mutation with projections#84158

Merged
alesapin merged 3 commits intomasterfrom
fix_crash_with_lighweight
Jul 23, 2025
Merged

Fix crash during lighweight mutation with projections#84158
alesapin merged 3 commits intomasterfrom
fix_crash_with_lighweight

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Jul 21, 2025

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix rare clickhouse crash when table has projection, lightweight_mutation_projection_mode = 'rebuild' and user execute lighweight delete which deletes ALL rows from any block in table.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@alesapin alesapin added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Jul 21, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 21, 2025 •
edited
Loading

Workflow [PR], commit [96a79ce]

Summary: ⏳

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel) failure
03100_lwu_27_update_after_on_fly_mutations FAIL

@antaljanosbenjamin antaljanosbenjamin self-assigned this Jul 21, 2025
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Jul 23, 2025

03100_lwu_27_update_after_on_fly_mutations is flaky. This test doesn't have any projections or lightweight deletes. My change is strictly related to combination of these two features and shouldn't affect it anyhow. I've created an issue: #84277

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Jul 23, 2025

I've checked CI database, there are no other failures of 03100_lwu_27_update_after_on_fly_mutations. If this test will become flaky after this merge I'll revert this pr.

@alesapin alesapin added this pull request to the merge queue Jul 23, 2025
Merged via the queue into master with commit 24dfe73 Jul 23, 2025
121 of 125 checks passed
@alesapin alesapin deleted the fix_crash_with_lighweight branch July 23, 2025 10:23
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 23, 2025
@robot-clickhouse robot-clickhouse added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Jul 23, 2025
This was referenced Jul 23, 2025
Closed
Closed
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Jul 23, 2025
@robot-clickhouse
Merge pull request #84285 from ClickHouse/cherrypick/25.5/84158
348704d 
Cherry pick #84158 to 25.5: Fix crash during lighweight mutation with projections
robot-clickhouse added a commit that referenced this pull request Jul 23, 2025
@robot-clickhouse
Backport #84158 to 25.5: Fix crash during lighweight mutation with pr…
ad931f8 
…ojections
This was referenced Jul 23, 2025
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jul 23, 2025
@robot-clickhouse
Merge pull request #84287 from ClickHouse/cherrypick/25.6/84158
ca429ab 
Cherry pick #84158 to 25.6: Fix crash during lighweight mutation with projections
robot-clickhouse added a commit that referenced this pull request Jul 23, 2025
@robot-clickhouse
Backport #84158 to 25.6: Fix crash during lighweight mutation with pr…
9e1bf73 
…ojections
This was referenced Jul 23, 2025
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jul 23, 2025
@robot-clickhouse
Merge pull request #84289 from ClickHouse/cherrypick/25.7/84158
eac34c7 
Cherry pick #84158 to 25.7: Fix crash during lighweight mutation with projections
robot-clickhouse added a commit that referenced this pull request Jul 23, 2025
@robot-clickhouse
Backport #84158 to 25.7: Fix crash during lighweight mutation with pr…
37f6f34 
…ojections
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 23, 2025
Merged
clickhouse-gh bot added a commit that referenced this pull request Jul 23, 2025
@clickhouse-gh
Merge pull request #84290 from ClickHouse/backport/25.7/84158
07b8c88 
Backport #84158 to 25.7: Fix crash during lighweight mutation with projections
alesapin added a commit that referenced this pull request Jul 23, 2025
@alesapin
Merge pull request #84286 from ClickHouse/backport/25.5/84158
8b38222 
Backport #84158 to 25.5: Fix crash during lighweight mutation with projections
alesapin added a commit that referenced this pull request Jul 23, 2025
@alesapin
Merge pull request #84288 from ClickHouse/backport/25.6/84158
524bb86 
Backport #84158 to 25.6: Fix crash during lighweight mutation with projections
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 8, 2025
@Algunenano Algunenano mentioned this pull request Sep 30, 2025
Merged
1 task
@alexey-milovidov alexey-milovidov mentioned this pull request Feb 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antaljanosbenjamin antaljanosbenjamin antaljanosbenjamin approved these changes

Assignees

@antaljanosbenjamin antaljanosbenjamin

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alesapin @antaljanosbenjamin @robot-clickhouse @robot-ch-test-poll3 @robot-clickhouse-ci-2