Skip to content

Bump curl from 8.14.0 to 8.15.0#84231

Merged
rschu1ze merged 2 commits intoClickHouse:masterfrom
rschu1ze:bump-curl
Jul 23, 2025
Merged

Bump curl from 8.14.0 to 8.15.0#84231
rschu1ze merged 2 commits intoClickHouse:masterfrom
rschu1ze:bump-curl

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Jul 22, 2025

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Bumped internal curl from 8.14.0 to 8.15.0

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 22, 2025

Workflow [PR], commit [d9f9115]

Summary:

job_name test_name status info comment
Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel) failure
++ error
Exception in test runner FAIL
Integration tests (release, 3/4) failure
Job Timeout Expired FAIL
Upgrade check (amd_msan) failure
S3_ERROR No such key thrown (see clickhouse-server.log or no_such_key_errors.txt) FAIL

@clickhouse-gh clickhouse-gh bot added pr-build Pull request with build/testing/packaging improvement submodule changed At least one submodule changed in this PR. labels Jul 22, 2025
@rschu1ze rschu1ze changed the title Bump curl from 8.14.0 to 8.14.1 Bump curl from 8.14.0 to 8.15.0 Jul 22, 2025
@rschu1ze rschu1ze force-pushed the bump-curl branch 2 times, most recently from 799a1ff to 46bb78b Compare July 22, 2025 16:36
@rschu1ze rschu1ze marked this pull request as ready for review July 22, 2025 16:38
#define HAVE_FCNTL_H
#define HAVE_NETDB_H
#define HAVE_NETINET_IN_H
#define HAVE_SELECT
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be problematic. Where is it used?

Copy link
Copy Markdown
Member Author

@rschu1ze rschu1ze Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It became mandatory as per curl 8.15.0 (used by "lib/curlx/wait.c" which does

#ifndef HAVE_SELECT
#error "We cannot compile without select() support."
#endif

and uses timeval in a wait function). It should be fine though, we include the same header from poco and c-ares already on all platforms.

@alexey-milovidov alexey-milovidov self-assigned this Jul 22, 2025
@rschu1ze
Copy link
Copy Markdown
Member Author

Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel):

  • Exception in test runner ... reported to CI team

Integration tests (release, 3/4):

  • Job Timeout Expired ... known to CI team (needs re-try)

@rschu1ze rschu1ze enabled auto-merge July 23, 2025 18:08
@rschu1ze rschu1ze added this pull request to the merge queue Jul 23, 2025
Merged via the queue into ClickHouse:master with commit 52750a6 Jul 23, 2025
120 of 123 checks passed
@rschu1ze rschu1ze deleted the bump-curl branch July 23, 2025 18:22
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 23, 2025
@rschu1ze rschu1ze added pr-must-backport Pull request should be backported intentionally. Use this label with great care! and removed pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-build Pull request with build/testing/packaging improvement pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants