Yet another sz3 fuzzer compression fix#84320
Merged
alexey-milovidov merged 4 commits intoClickHouse:masterfrom Jul 24, 2025
Merged
Yet another sz3 fuzzer compression fix#84320alexey-milovidov merged 4 commits intoClickHouse:masterfrom
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
Conversation
Contributor
|
Workflow [PR], commit [95923e2] Summary: ❌
|
Member
There was a problem hiding this comment.
Does it have to be hard-coded?
Member
Author
There was a problem hiding this comment.
Yet, because it is not declared (I just calculated the minimal size of decompressed config) and it is less than sizeof(SZ3::Config)
alexey-milovidov
requested changes
Jul 23, 2025
Member
alexey-milovidov
left a comment
alexey-milovidov
left a comment
There was a problem hiding this comment.
Line 210, case 4: { - the style requires opening curly braces on a new line.
scanhex12
force-pushed
the
yet_another_fix
branch
from
f13933c to
a8e664b
Compare
Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
alexey-milovidov
approved these changes
Jul 24, 2025
robot-clickhouse-ci-2
added
the
pr-synced-to-cloud
robot-ch-test-poll2
added
pr-backports-created-cloud
robot-ch-test-poll
added
the
pr-backports-created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes