Skip to content

Fix leaks for keeper with rocksdb storage (iterators was not destroyed)#84523

Merged
azat merged 3 commits intoClickHouse:masterfrom
azat:keeper-rocksdb-leak
Jul 28, 2025
Merged

Fix leaks for keeper with rocksdb storage (iterators was not destroyed)#84523
azat merged 3 commits intoClickHouse:masterfrom
azat:keeper-rocksdb-leak

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jul 27, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix leaks for keeper with rocksdb storage (iterators was not destroyed)

CI: https://s3.amazonaws.com/clickhouse-test-reports/PRs/84084/a27e4fcb365a35641c75fc886c90dafc8418b812//unit_tests_asan/job.log

@azat azat requested review from antonio2368 and hanfei1991 July 27, 2025 16:56
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 27, 2025

Workflow [PR], commit [028fe59]

Summary:

job_name test_name status info comment
Stateless tests (amd_asan, distributed plan, sequential) failure
00002_log_and_exception_messages_formatting FAIL
Stress test (amd_msan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL
Performance Comparison (amd_release, master_head, 3/3) error
Finish Workflow failure
python3 ./ci/jobs/scripts/workflow_hooks/new_tests_check.py failure

@hanfei1991 hanfei1991 self-assigned this Jul 27, 2025
@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jul 27, 2025
@azat azat enabled auto-merge July 27, 2025 17:20
@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 28, 2025

CI:

Stateless tests (amd_asan, distributed plan, sequential)

  • 00002_log_and_exception_messages_formatting

Stress test (amd_msan)

  • assertHasValidVersionMetadata - fix is in progress

Performance Comparison (amd_release, master_head, 3/3)

@azat azat added this pull request to the merge queue Jul 28, 2025
Merged via the queue into ClickHouse:master with commit f6477d4 Jul 28, 2025
120 of 125 checks passed
@azat azat deleted the keeper-rocksdb-leak branch July 28, 2025 06:19
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants