Skip to content

Support read_in_order_use_virtual_row for WHERE.#84835

Merged
KochetovNicolai merged 3 commits intomasterfrom
read_in_order_use_virtual_row-support-where
Aug 4, 2025
Merged

Support read_in_order_use_virtual_row for WHERE.#84835
KochetovNicolai merged 3 commits intomasterfrom
read_in_order_use_virtual_row-support-where

Conversation

@KochetovNicolai
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai commented Jul 31, 2025 •
edited
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Add missing support of read_in_order_use_virtual_row for WHERE. It allows to skip reading more parts for queries with filters that were not fully pushed to PREWHERE.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 31, 2025 •
edited
Loading

Workflow [PR], commit [4efcc4c]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel) failure
Logical error thrown (see clickhouse-server.log or logical_errors.txt) FAIL

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Jul 31, 2025
@vdimir vdimir self-assigned this Aug 1, 2025
@vdimir
Copy link
Copy Markdown
Member

vdimir commented Aug 1, 2025 •
edited
Loading

Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel)
FAIL 03581_read_in_order_use_virtual_row_WHERE 2.40

2025-07-31 23:07:39 Reason: result differs with reference:  
2025-07-31 23:07:39 --- /home/ubuntu/actions-runner/_work/ClickHouse/ClickHouse/tests/queries/0_stateless/03581_read_in_order_use_virtual_row_WHERE.reference	2025-07-31 23:01:06.083039700 +0430
2025-07-31 23:07:39 +++ /home/ubuntu/actions-runner/_work/ClickHouse/ClickHouse/tests/queries/0_stateless/03581_read_in_order_use_virtual_row_WHERE.stdout	2025-07-31 23:07:39.767034840 +0430
2025-07-31 23:07:39 @@ -3,14 +3,14 @@
2025-07-31 23:07:39  0
2025-07-31 23:07:39  1024
2025-07-31 23:07:39  2048
2025-07-31 23:07:39  3072
2025-07-31 23:07:39  4096
2025-07-31 23:07:39  5120
2025-07-31 23:07:39  6144
2025-07-31 23:07:39  7168
2025-07-31 23:07:39  8192
2025-07-31 23:07:39  9216
2025-07-31 23:07:39 -MergeTreeSelect(pool: ReadPoolInOrder, algorithm: InOrder)	0
2025-07-31 23:07:39 -MergeTreeSelect(pool: ReadPoolInOrder, algorithm: InOrder)	57344
2025-07-31 23:07:39 +MergeTreeSelect(pool: ReadPoolParallelReplicasInOrder, algorithm: InOrder)	0
2025-07-31 23:07:39 +MergeTreeSelect(pool: ReadPoolParallelReplicasInOrder, algorithm: InOrder)	57344
2025-07-31 23:07:39  VirtualRowTransform	0
2025-07-31 23:07:39  VirtualRowTransform	57344
2025-07-31 23:07:39 
2025-07-31 23:07:39 
2025-07-31 23:07:39 
2025-07-31 23:07:39 Database: test_vj9en0ix

Also Expected JOIN table expression to be table, table function, query or union node still fails, in many PRs, checking ...

@KochetovNicolai
Copy link
Copy Markdown
Member Author

KochetovNicolai commented Aug 4, 2025

#81144

@KochetovNicolai KochetovNicolai added this pull request to the merge queue Aug 4, 2025
Merged via the queue into master with commit 35ce6ae Aug 4, 2025
361 of 364 checks passed
@KochetovNicolai KochetovNicolai deleted the read_in_order_use_virtual_row-support-where branch August 4, 2025 10:02
@robot-ch-test-poll2 robot-ch-test-poll2 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Aug 4, 2025
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdimir vdimir vdimir approved these changes

Assignees

@vdimir vdimir

Labels

pr-backports-created-cloud deprecated label, NOOP pr-improvement Pull request with some product improvements pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KochetovNicolai @vdimir @robot-clickhouse @robot-ch-test-poll2