Skip to content

Fix Keeper watches count again#84890

Merged
antonio2368 merged 1 commit intomasterfrom
keeper-watches-count
Aug 4, 2025
Merged

Fix Keeper watches count again#84890
antonio2368 merged 1 commit intomasterfrom
keeper-watches-count

Conversation

@antonio2368
Copy link
Copy Markdown
Member

@antonio2368 antonio2368 commented Aug 1, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix total watches count returned by Keeper.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@antonio2368 antonio2368 added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Aug 1, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 1, 2025 •
edited
Loading

Workflow [PR], commit [7351503]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel) failure
Logical error thrown (see clickhouse-server.log or logical_errors.txt) FAIL
Stress test (amd_tsan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Aug 1, 2025
antaljanosbenjamin
antaljanosbenjamin approved these changes Aug 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@antaljanosbenjamin antaljanosbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@antonio2368 antonio2368 added this pull request to the merge queue Aug 4, 2025
Merged via the queue into master with commit 5ddd960 Aug 4, 2025
122 of 124 checks passed
@antonio2368 antonio2368 deleted the keeper-watches-count branch August 4, 2025 07:51
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 4, 2025
@robot-ch-test-poll robot-ch-test-poll added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Aug 4, 2025
This was referenced Aug 4, 2025
Closed
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Aug 4, 2025
@robot-ch-test-poll2
Merge pull request #84988 from ClickHouse/cherrypick/25.3/84890
acc9729 
Cherry pick #84890 to 25.3: Fix Keeper watches count again
robot-clickhouse added a commit that referenced this pull request Aug 4, 2025
@robot-clickhouse
Backport #84890 to 25.3: Fix Keeper watches count again
bd966ce
This was referenced Aug 4, 2025
Merged
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Aug 4, 2025
@robot-ch-test-poll2
Merge pull request #84990 from ClickHouse/cherrypick/25.5/84890
ab6660c 
Cherry pick #84890 to 25.5: Fix Keeper watches count again
robot-clickhouse added a commit that referenced this pull request Aug 4, 2025
@robot-clickhouse
Backport #84890 to 25.5: Fix Keeper watches count again
d67787c
This was referenced Aug 4, 2025
Merged
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Aug 4, 2025
@robot-ch-test-poll2
Merge pull request #84992 from ClickHouse/cherrypick/25.6/84890
33dc6e2 
Cherry pick #84890 to 25.6: Fix Keeper watches count again
robot-clickhouse added a commit that referenced this pull request Aug 4, 2025
@robot-clickhouse
Backport #84890 to 25.6: Fix Keeper watches count again
3c2007f
This was referenced Aug 4, 2025
Merged
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Aug 4, 2025
@robot-ch-test-poll2
Merge pull request #84994 from ClickHouse/cherrypick/25.7/84890
58eb032 
Cherry pick #84890 to 25.7: Fix Keeper watches count again
robot-clickhouse added a commit that referenced this pull request Aug 4, 2025
@robot-clickhouse
Backport #84890 to 25.7: Fix Keeper watches count again
005313e
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Aug 4, 2025
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 4, 2025
clickhouse-gh bot added a commit that referenced this pull request Aug 4, 2025
@clickhouse-gh
Merge pull request #84993 from ClickHouse/backport/25.6/84890
721f11a 
Backport #84890 to 25.6: Fix Keeper watches count again
clickhouse-gh bot added a commit that referenced this pull request Aug 4, 2025
@clickhouse-gh
Merge pull request #84995 from ClickHouse/backport/25.7/84890
9c0e30f 
Backport #84890 to 25.7: Fix Keeper watches count again
antonio2368 added a commit that referenced this pull request Aug 4, 2025
@antonio2368
Merge pull request #84989 from ClickHouse/backport/25.3/84890
3f6e8ab 
Backport #84890 to 25.3: Fix Keeper watches count again
antonio2368 added a commit that referenced this pull request Aug 4, 2025
@antonio2368
Merge pull request #84991 from ClickHouse/backport/25.5/84890
55ed340 
Backport #84890 to 25.5: Fix Keeper watches count again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antaljanosbenjamin antaljanosbenjamin antaljanosbenjamin approved these changes

Assignees

@antaljanosbenjamin antaljanosbenjamin

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@antonio2368 @antaljanosbenjamin @robot-clickhouse @robot-ch-test-poll @robot-ch-test-poll1