Allow to use bigger timeouts for zookeeper

[azat]

I am using bigger timeouts for development (3600 seconds) to avoid disconnects in case of attaching with debugger, but this may trigger UB due to overflow:

src/Common/ZooKeeper/ZooKeeperImpl.cpp:556:68: runtime error: signed integer overflow: 3600000 * 1000 cannot be represented in type 'int'

Changelog category (leave one):

• Not for changelog (changelog entry is not required)

[clickhouse-gh]

Workflow [PR], commit [e902388]

Summary: ❌

job_name	test_name	status	info	comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel)		failure
	02443_detach_attach_partition	FAIL
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, sequential)		failure
	01154_move_partition_long	FAIL
Integration tests (aarch64, distributed plan, 4/4)		failure
	test_storage_rabbitmq/test.py::test_rabbitmq_vhost	FAIL
	test_storage_rabbitmq/test.py::test_rabbitmq_format_factory_settings	FAIL

[tuanpach]

I am using bigger timeouts for development (3600 seconds)
src/Common/ZooKeeper/ZooKeeperImpl.cpp:556:68: runtime error: signed integer overflow: 3600000 * 1000 cannot be represented in type 'int'

Should the value be 3600*1000 ms instead of 3600000 * 1000?

[azat]

Should the value be 3600*1000 ms instead of 3600000 * 1000?

The last is correct, the value in config accept ms, I put 3600_000 in config, but later to pass timeout to socket poco converts it to microseconds, this is 1000x more, and so it exceeds INT_MAX

[antonio2368]

We cannot do this because protocol defines timeout as int32 and that's what we will write and read in handshake.

Can't change the type to Int64

https://github.com/ClickHouse/ClickHouse/blob/master/src/Common/ZooKeeper/ZooKeeperImpl.cpp

[azat]

We cannot do this because protocol defines timeout as int32 and that's what we will write and read in handshake.

Thanks, then, let's do it another way, @antonio2368 PTAL

[antonio2368]

This looks good
Always some issues with Poco::Timespan 😞

[azat]

CI:

• 01154_move_partition_long is flaky #80315
• Flaky integration test test_storage_rabbitmq #71049
• 02443_detach_attach_partition is flaky  #54748