Avoid some copies in Keeper#85131
Merged
antonio2368 merged 3 commits intomasterfrom Aug 8, 2025
Merged
Conversation
Contributor
clickhouse-gh
Bot
added
the
pr-not-for-changelog
vdimir
reviewed
Aug 6, 2025
Member
There was a problem hiding this comment.
Why can we move(children)? Doesn't it make the current object malformed?
Member
There was a problem hiding this comment.
In shallowCopy we copy stats but not children, so getChildren on on object with was obtained via shallowCopy will trigger assert, is it intended?
Member
Author
There was a problem hiding this comment.
It is a bit hacky, when creating snapshot we don't iterate children.
If snapshot is being made, each update of a node will create a copy first and then update it.
Snapshot will use the old node, while every new operation will use new node.
So that's why we can move children from the snapshotted node, we don't need it.
Member
Author
There was a problem hiding this comment.
This deserves a comment.
Member
Author
There was a problem hiding this comment.
As a safety I added asserts on children getters (getChildren)
antonio2368
force-pushed
the
keeper-avoid-some-copies
branch
3 times, most recently
from
672e894 to
09f736f
Compare
antonio2368
force-pushed
the
keeper-avoid-some-copies
branch
from
09f736f to
8c6f6dd
Compare
antonio2368
added
the
pr-must-backport
alexey-milovidov
removed
the
pr-must-backport
Member
|
@antonio2368 Wrong category. |
vdimir
approved these changes
Aug 7, 2025
antonio2368
added
the
pr-must-backport
robot-ch-test-poll
added
the
pr-synced-to-cloud
robot-clickhouse-ci-2
added
pr-backports-created-cloud
This was referenced Aug 8, 2025
robot-clickhouse
added a commit
that referenced
this pull request
Aug 8, 2025
This was referenced Aug 8, 2025
robot-clickhouse
added a commit
that referenced
this pull request
Aug 8, 2025
This was referenced Aug 8, 2025
robot-clickhouse
added a commit
that referenced
this pull request
Aug 8, 2025
This was referenced Aug 8, 2025
robot-clickhouse
added a commit
that referenced
this pull request
Aug 8, 2025
robot-clickhouse-ci-2
added
the
pr-backports-created
clickhouse-gh Bot
added a commit
that referenced
this pull request
Aug 8, 2025
Backport #85131 to 25.7: Avoid some copies in Keeper
clickhouse-gh Bot
added a commit
that referenced
this pull request
Aug 8, 2025
Backport #85131 to 25.6: Avoid some copies in Keeper
antonio2368
added a commit
that referenced
this pull request
Aug 11, 2025
Backport #85131 to 25.3: Avoid some copies in Keeper
antonio2368
added a commit
that referenced
this pull request
Aug 11, 2025
Backport #85131 to 25.5: Avoid some copies in Keeper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Documentation entry for user-facing changes