Fix reading count() from cache in case of partitioned delta lake#85704
Merged
Fix reading count() from cache in case of partitioned delta lake#85704
Conversation
kssenii
commented
Aug 15, 2025
Member
Author
There was a problem hiding this comment.
A bit of extra diff in this file, because of applied black formatting.
Contributor
|
Workflow [PR], commit [2dc95ef] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-bugfix
kssenii
commented
Aug 15, 2025
| ColumnWithTypeAndName count_column(column_type->createColumn(), column_type, column_name); | ||
| builder.init(Pipe(std::make_shared<ConstChunkGenerator>( | ||
| std::make_shared<const Block>(read_from_format_info.format_header), *num_rows_from_cache, max_block_size))); | ||
| std::make_shared<const Block>(ColumnsWithTypeAndName{count_column}), *num_rows_from_cache, max_block_size))); |
Member
Author
There was a problem hiding this comment.
Here there was a problem when format_header was used, because partition columns are read not from file, but from file path, so if this column was chosen to execute count, then format header will be empty, and below we will get and error "not found column in block"
Avogar
approved these changes
Aug 15, 2025
Member
Author
|
robot-ch-test-poll
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix reading count from cache for delta lake.
Documentation entry for user-facing changes