Revert "Revert "Fix inconsistent formatting of TTL""#85749
Merged
alexey-milovidov merged 8 commits intomasterfrom Oct 13, 2025
Merged
Revert "Revert "Fix inconsistent formatting of TTL""#85749alexey-milovidov merged 8 commits intomasterfrom
alexey-milovidov merged 8 commits intomasterfrom
Conversation
Contributor
|
Workflow [PR], commit [5f351aa] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-not-for-changelog
…82831-fix-inconsistent-formatting-ttl
…82831-fix-inconsistent-formatting-ttl
clickhouse-gh
bot
added
pr-improvement
alexey-milovidov
deleted the
revert-84475-revert-82831-fix-inconsistent-formatting-ttl
branch
PedroTadim
reviewed
Oct 21, 2025
| @@ -0,0 +1,3 @@ | |||
| DROP TABLE IF EXISTS t0; | |||
| CREATE TABLE t0 (c0 Date) ENGINE = MergeTree() ORDER BY () TTL (materialize(c0)); | |||
Member
There was a problem hiding this comment.
If the TTL is set on the column, it will also work, right?
Member
Author
There was a problem hiding this comment.
It should. Although this case is not really important (whether a TTL expression starting with the materialize function works or not), the goal here is to avoid "inconsistent parsing".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix inconsistent formatting of TTL when it contains a
materializefunction. Closes #82828.