Skip to content

Moved catalog unity, glue and iceberg to beta#85848

Merged
kssenii merged 16 commits intomasterfrom
catalog_beta
Aug 22, 2025
Merged

Moved catalog unity, glue and iceberg to beta#85848
kssenii merged 16 commits intomasterfrom
catalog_beta

Conversation

@melvynator
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Experimental Feature

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Moved catalog to beta

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@melvynator melvynator requested a review from kssenii August 19, 2025 04:24
Comment on lines +65 to +67
{"allow_database_iceberg", false, false, "Added an alias for setting `allow_experimental_database_iceberg`"},
{"allow_database_unity_catalog", false, false, "Added an alias for setting `allow_experimental_database_unity_catalog`"},
{"allow_database_glue_catalog", false, false, "Added an alias for setting `allow_experimental_database_glue_catalog`"},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{"allow_database_iceberg", false, false, "Added an alias for setting `allow_experimental_database_iceberg`"},
{"allow_database_unity_catalog", false, false, "Added an alias for setting `allow_experimental_database_unity_catalog`"},
{"allow_database_glue_catalog", false, false, "Added an alias for setting `allow_experimental_database_glue_catalog`"},
{"allow_database_iceberg", true, true, "Added an alias for setting `allow_experimental_database_iceberg`"},
{"allow_database_unity_catalog", true, true, "Added an alias for setting `allow_experimental_database_unity_catalog`"},
{"allow_database_glue_catalog", true, true, "Added an alias for setting `allow_experimental_database_glue_catalog`"},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this will affect the default value for services with compatiblity setting)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

node1.query(
f"create database unity_test_{test_uuid} engine DataLakeCatalog('http://localhost:8080/api/2.1/unity-catalog') settings warehouse = 'unity', catalog_type='unity', vended_credentials=false, allow_experimental_delta_kernel_rs={use_delta_kernel}",
settings={"allow_experimental_database_unity_catalog": "1"},
settings={"allow_database_unity_catalog": "1"},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave the old setting allow_experimental_database_unity_catalog in some of the tests to make sure it still works along with the new one.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also changed it for glue and Iceberg rest

@kssenii kssenii self-assigned this Aug 19, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 19, 2025

Workflow [PR], commit [8a44b5a]

Summary:

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel) failure
02443_detach_attach_partition FAIL
Stateless tests (amd_debug, AsyncInsert, s3 storage, parallel) failure
02443_detach_attach_partition FAIL
Integration tests (amd_asan, old analyzer, 1/6) failure
test_threadpool_readers/test.py::test_local_fs_threadpool_reader FAIL
Integration tests (arm_binary, distributed plan, 1/4) failure
test_memory_limit/test.py::test_multiple_queries FAIL
Integration tests (arm_binary, distributed plan, 3/4) failure
test_s3_plain_rewritable/test.py::test[s3_plain_rewritable_with_metadata_cache-data_with_cache/] FAIL
Install packages (amd_debug) failure
Run server init.d failure

@clickhouse-gh clickhouse-gh bot added the pr-experimental Experimental Feature label Aug 19, 2025
@kssenii kssenii added this pull request to the merge queue Aug 22, 2025
Merged via the queue into master with commit 67b2cf9 Aug 22, 2025
117 of 122 checks passed
@kssenii kssenii deleted the catalog_beta branch August 22, 2025 16:03
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-experimental Experimental Feature pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants