Fix HTTP host header in url() function#85921
Merged
scanhex12 merged 1 commit intoClickHouse:masterfrom Aug 20, 2025
Merged
Conversation
Contributor
|
Workflow [PR], commit [051463f] Summary: ❌
|
scanhex12
approved these changes
Aug 20, 2025
Contributor
Author
|
@scanhex12 Thanks for the approval. Any guidance on whether the failing tests are related to the change? To me they look unrelated but this is also my first PR against the ClickHouse repo. |
Member
|
@tomquist it's okay, failed tests are really unrelated - it's our CI problem. I'll merge your PR |
Merged
via the queue into
ClickHouse:master
with commit Aug 20, 2025
3f6cdc1
119 of 122 checks passed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fixes HTTP requests made by the
url()table function to properly include port numbers in the Host header when accessing non-standard ports. This resolves authentication failures when using presigned URLs with S3-compatible services like MinIO running on custom ports, which is common in development environments. (Fixes #85898)