Skip to content

Fix HTTP host header in url() function#85921

Merged
scanhex12 merged 1 commit intoClickHouse:masterfrom
tomquist:fix-issue-85898
Aug 20, 2025
Merged

Fix HTTP host header in url() function#85921
scanhex12 merged 1 commit intoClickHouse:masterfrom
tomquist:fix-issue-85898

Conversation

@tomquist
Copy link
Copy Markdown
Contributor

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fixes HTTP requests made by the url() table function to properly include port numbers in the Host header when accessing non-standard ports. This resolves authentication failures when using presigned URLs with S3-compatible services like MinIO running on custom ports, which is common in development environments. (Fixes #85898)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 20, 2025

CLA assistant check
All committers have signed the CLA.

@scanhex12 scanhex12 self-assigned this Aug 20, 2025
@scanhex12 scanhex12 added the can be tested Allows running workflows for external contributors label Aug 20, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 20, 2025

Workflow [PR], commit [051463f]

Summary:

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel) failure
02443_detach_attach_partition FAIL
03031_minmax_index_for_pointinpolygon FAIL
02024_compression_in_query FAIL
Exception in test runner FAIL
Killed by signal (in clickhouse-server.log or clickhouse-server.err.log) FAIL
Fatal messages (in clickhouse-server.log or clickhouse-server.err.log) FAIL
Stateless tests (amd_debug, AsyncInsert, s3 storage, parallel) failure
01086_odbc_roundtrip FAIL
Install packages (amd_debug) failure
Run server init.d failure

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Aug 20, 2025
@tomquist tomquist changed the title Update HTTP header tests for explicit port Fix HTTP host header in url() function Aug 20, 2025
@tomquist
Copy link
Copy Markdown
Contributor Author

@scanhex12 Thanks for the approval. Any guidance on whether the failing tests are related to the change? To me they look unrelated but this is also my first PR against the ClickHouse repo.

@scanhex12
Copy link
Copy Markdown
Member

@tomquist it's okay, failed tests are really unrelated - it's our CI problem. I'll merge your PR

@scanhex12 scanhex12 added this pull request to the merge queue Aug 20, 2025
Merged via the queue into ClickHouse:master with commit 3f6cdc1 Aug 20, 2025
119 of 122 checks passed
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClickHouse strips port from Host header in HTTP requests, breaking AWS signature validation for presigned URLs on non-standard ports

4 participants