Skip to content

Don't create empty iceberg delete file#86061

Merged
scanhex12 merged 3 commits intoClickHouse:masterfrom
scanhex12:dont_write_empty_pos_delete_file
Aug 22, 2025
Merged

Don't create empty iceberg delete file#86061
scanhex12 merged 3 commits intoClickHouse:masterfrom
scanhex12:dont_write_empty_pos_delete_file

Conversation

@scanhex12
Copy link
Copy Markdown
Member

Test "create empty table + delete some key" gives segfault.

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Don't create empty iceberg delete file

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 22, 2025

Workflow [PR], commit [769071c]

Summary:

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel) failure
Lost s3 keys FAIL
S3_ERROR No such key thrown (in clickhouse-server.log or clickhouse-server.err.log) FAIL
Stateless tests (amd_debug, AsyncInsert, s3 storage, parallel) failure
01086_odbc_roundtrip FAIL
Integration tests (arm_binary, distributed plan, 3/4) failure
test_global_overcommit_tracker/test.py::test_global_overcommit FAIL
Integration tests (amd_tsan, 1/6) failure
test_checking_s3_blobs_paranoid/test.py::test_when_s3_connection_reset_by_peer_at_upload_is_retried[True] FAIL
Integration tests (amd_asan, flaky check) failure
test_storage_iceberg/test.py::test_filesystem_cache[s3-1-3] FAIL
test_storage_iceberg/test.py::test_metadata_cache[azure-1-3] FAIL
test_storage_iceberg/test.py::test_metadata_cache[s3-2-3] FAIL

@kssenii kssenii self-assigned this Aug 22, 2025
@scanhex12 scanhex12 enabled auto-merge August 22, 2025 17:05
@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Aug 22, 2025
@scanhex12 scanhex12 added this pull request to the merge queue Aug 22, 2025
Merged via the queue into ClickHouse:master with commit f55231a Aug 22, 2025
115 of 121 checks passed
@scanhex12 scanhex12 deleted the dont_write_empty_pos_delete_file branch August 22, 2025 20:49
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 22, 2025
@robot-ch-test-poll robot-ch-test-poll added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Aug 22, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants