Skip to content

Fix crash with replaceRegex, a FixedString haystack and an empty needle#86270

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Algunenano:replace_regex_fixedstring_empty_needle
Aug 28, 2025
Merged

Fix crash with replaceRegex, a FixedString haystack and an empty needle#86270
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Algunenano:replace_regex_fixedstring_empty_needle

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Aug 27, 2025 •
edited
Loading

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix crash with replaceRegex, a FixedString haystack and an empty needle

Closes #86261.
Closes #86260
Introduced in #85063 (Only pre-released 25.8)

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 27, 2025 •
edited
Loading

Workflow [PR], commit [8a98d5e]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel) failure
02443_detach_attach_partition FAIL
Stateless tests (amd_msan, parallel, 1/2) failure
03555_json_shared_data_advanced_paths_indexes FAIL
Stateless tests (amd_tsan, s3 storage, parallel) failure
03212_variant_dynamic_cast_or_default FAIL
Stateless tests (arm_binary, parallel) failure
01825_new_type_json_ghdata_insert_select FAIL

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Aug 27, 2025
@Algunenano Algunenano removed pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Aug 27, 2025
@Avogar Avogar self-assigned this Aug 27, 2025
@Avogar Avogar closed this Aug 27, 2025
@Avogar Avogar reopened this Aug 27, 2025
@Avogar
Copy link
Copy Markdown
Member

Avogar commented Aug 27, 2025 •
edited
Loading

Sorry for closing and reopening it, I got insane for a minute

@alexey-milovidov alexey-milovidov merged commit 3c93493 into ClickHouse:master Aug 28, 2025
263 of 271 checks passed
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Aug 28, 2025
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Aug 28, 2025
@robot-ch-test-poll2
Merge pull request #86319 from ClickHouse/cherrypick/25.8/86270
3454666 
Cherry pick #86270 to 25.8: Fix crash with replaceRegex, a FixedString haystack and an empty needle
robot-clickhouse added a commit that referenced this pull request Aug 28, 2025
@robot-clickhouse
Backport #86270 to 25.8: Fix crash with replaceRegex, a FixedString h…
7078a1d 
…aystack and an empty needle
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Aug 28, 2025
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 28, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Aug 28, 2025
@robot-clickhouse robot-clickhouse added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 28, 2025
clickhouse-gh bot added a commit that referenced this pull request Aug 28, 2025
@clickhouse-gh
Merge pull request #86320 from ClickHouse/backport/25.8/86270
bd9fcca 
Backport #86270 to 25.8: Fix crash with replaceRegex, a FixedString haystack and an empty needle
This was referenced Sep 4, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avogar Avogar Avogar approved these changes

Assignees

@Avogar Avogar

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-critical-bugfix pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v25.8-must-backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash in CRC32Hash heap-buffer-overflow in DistinctTransform, ColumnsHashingImpl

6 participants

@Algunenano @Avogar @alexey-milovidov @robot-clickhouse @robot-ch-test-poll1 @robot-clickhouse-ci-2