Skip to content

Feature: Add support for temporary views #79426#86432

Merged
azat merged 10 commits intoClickHouse:masterfrom
AlyHKafoury:Support-for-temporary-views
Sep 4, 2025
Merged

Feature: Add support for temporary views #79426#86432
azat merged 10 commits intoClickHouse:masterfrom
AlyHKafoury:Support-for-temporary-views

Conversation

@AlyHKafoury
Copy link
Copy Markdown
Contributor

@AlyHKafoury AlyHKafoury commented Aug 31, 2025

Resolves : #79426

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Allows users to create temporary views with the same syntax as temporary tables.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 31, 2025

CLA assistant check
All committers have signed the CLA.

@AlyHKafoury AlyHKafoury marked this pull request as ready for review August 31, 2025 16:38
@azat azat self-assigned this Sep 1, 2025
Copy link
Copy Markdown
Member

@azat azat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please take a look at the comments.

@azat azat added the can be tested Allows running workflows for external contributors label Sep 1, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 1, 2025

Workflow [PR], commit [b281403]

Summary:

job_name test_name status info comment
Build (fuzzers) failure
Build ClickHouse failure

@clickhouse-gh clickhouse-gh bot added the pr-feature Pull request with new product feature label Sep 1, 2025
@AlyHKafoury
Copy link
Copy Markdown
Contributor Author

@azat I believe the failing checks are race conditions which fail randomly ?

@AlyHKafoury AlyHKafoury requested a review from azat September 3, 2025 07:26
@azat
Copy link
Copy Markdown
Member

azat commented Sep 3, 2025

I believe the failing checks are race conditions which fail randomly ?

Yep, those tests are flaky, and the build problem is also flaky thing, you can ignore this.

@AlyHKafoury AlyHKafoury requested a review from azat September 3, 2025 18:54
@AlyHKafoury
Copy link
Copy Markdown
Contributor Author

@azat I believe I have addressed all the points also the integration tests and the functional tests are working fine

@azat
Copy link
Copy Markdown
Member

azat commented Sep 3, 2025

I believe I have addressed all the points also the integration tests and the functional tests are working fine

Lots of jobs had been cancelled due to flaky tests, I've restarted all failed jobs

@azat azat enabled auto-merge September 4, 2025 08:13
@azat
Copy link
Copy Markdown
Member

azat commented Sep 4, 2025

Looks OK now

@azat azat added this pull request to the merge queue Sep 4, 2025
Merged via the queue into ClickHouse:master with commit e6a1107 Sep 4, 2025
233 of 240 checks passed
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for temporary views

4 participants