Skip to content

Nullablity bugs in insert and pruning#86630

Merged
scanhex12 merged 4 commits intoClickHouse:masterfrom
scanhex12:fix_nulls_bug
Sep 3, 2025
Merged

Nullablity bugs in insert and pruning#86630
scanhex12 merged 4 commits intoClickHouse:masterfrom
scanhex12:fix_nulls_bug

Conversation

@scanhex12
Copy link
Copy Markdown
Member

@scanhex12 scanhex12 commented Sep 3, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Nullablity bugs in insert and pruning. This closes #86407

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 3, 2025 •
edited
Loading

Workflow [PR], commit [caee94e]

Summary: ⏳

job_name test_name status info comment
Stateless tests (amd_asan, distributed plan, sequential) failure
Start ClickHouse Server failure
Stateless tests (amd_ubsan, parallel) failure
Server died FAIL
Exception in test runner FAIL
Integration tests (amd_asan, old analyzer, 5/6) failure
test_restore_replica/test.py::test_restore_replica_sequential FAIL
Integration tests (amd_asan, flaky check) failure
test_storage_iceberg/test.py::test_metadata_cache[azure-3-3] FAIL
test_storage_iceberg/test.py::test_filesystem_cache[s3-3-3] FAIL
test_storage_iceberg/test.py::test_metadata_cache[s3-2-3] FAIL
test_storage_iceberg/test.py::test_metadata_cache[azure-1-3] FAIL
test_storage_iceberg/test.py::test_filesystem_cache[s3-2-3] FAIL
test_storage_iceberg/test.py::test_metadata_cache[s3-1-3] FAIL
test_storage_iceberg/test.py::test_metadata_cache[azure-2-3] FAIL
test_storage_iceberg/test.py::test_metadata_cache[s3-3-3] FAIL

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Sep 3, 2025
@divanik divanik self-assigned this Sep 3, 2025
@divanik divanik added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Sep 3, 2025
@scanhex12 scanhex12 added this pull request to the merge queue Sep 3, 2025
Merged via the queue into ClickHouse:master with commit 59e96b6 Sep 3, 2025
112 of 121 checks passed
@scanhex12 scanhex12 deleted the fix_nulls_bug branch September 3, 2025 22:32
This was referenced Sep 3, 2025
Closed
Closed
Closed
Closed
PedroTadim
PedroTadim reviewed Sep 4, 2025
View reviewed changes
tests/integration/test_storage_iceberg/test.py
create_iceberg_table(storage_type, instance, TABLE_NAME, started_cluster, "(c0 Nullable(String))", format_version, "(c0)")
instance.query(f"INSERT INTO {TABLE_NAME} VALUES (NULL), ('Monetochka'), ('Maneskin'), ('Noize MC');", settings={"allow_experimental_insert_into_iceberg": 1})

assert instance.query(f"SELECT * FROM {TABLE_NAME} ORDER BY ALL") == 'Maneskin\nMonetochka\nNoize MC\n\\N\n'
Copy link
Copy Markdown
Member

@PedroTadim PedroTadim Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see the PARTITION BY test case, but it should be fixed too?

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 4, 2025
@robot-ch-test-poll4 robot-ch-test-poll4 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Sep 4, 2025
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PedroTadim PedroTadim PedroTadim left review comments

@divanik divanik divanik approved these changes

Assignees

@divanik divanik

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

INSERTS to Iceberg table don't work with NULL values

6 participants

@scanhex12 @PedroTadim @divanik @robot-ch-test-poll @robot-ch-test-poll4 @robot-ch-test-poll3