Fix IPv6 support in listen_host for ArrowFlight#86664
Merged
vitlibar merged 1 commit intoClickHouse:masterfrom Sep 4, 2025
Merged
Fix IPv6 support in listen_host for ArrowFlight#86664vitlibar merged 1 commit intoClickHouse:masterfrom
vitlibar merged 1 commit intoClickHouse:masterfrom
Conversation
Contributor
|
Workflow [PR], commit [12b0084] Summary: ❌
|
vitlibar
commented
Sep 4, 2025
| auto port_to_listen = address_to_listen.port(); | ||
|
|
||
| /// Function arrow::flight::Location::ForGrpc*() builds an URL based so it requires IPv6 address to be enclosed in brackets | ||
| String host_component = (ip_to_listen.family() == Poco::Net::AddressFamily::IPv6) ? ("[" + ip_to_listen.toString() + "]") : ip_to_listen.toString(); |
Member
Author
There was a problem hiding this comment.
The problem was here because an IPv6 address needs to be enclosed in brackets, we can't just insert it into URL, so the following is incorrect:
grpc+tcp://:::8888
(it should be grpc+tcp://[::]:8888)
Member
Author
|
Probably it would be worth adding a test, but our test system is not set up for using IPv6. |
evillique
approved these changes
Sep 4, 2025
Member
Author
|
CI failures are unrelated: |
Merged
via the queue into
ClickHouse:master
with commit Sep 4, 2025
d9b5f8c
228 of 240 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix support for IPv6 in
listen_hostfor ArrowFlight.Before this PR a server with the following lines in the config
failed on startup with the following exception: