Skip to content

Fix shutdown of ArrowFlight handler#86665

Merged
vitlibar merged 1 commit intoClickHouse:masterfrom
vitlibar:fix-shutdown-in-arrow-flight-handler
Sep 4, 2025
Merged

Fix shutdown of ArrowFlight handler#86665
vitlibar merged 1 commit intoClickHouse:masterfrom
vitlibar:fix-shutdown-in-arrow-flight-handler

Conversation

@vitlibar
Copy link
Copy Markdown
Member

@vitlibar vitlibar commented Sep 4, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix shutdown in ArrowFlight handler.
This PR fixes #86596

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 4, 2025 •
edited
Loading

Workflow [PR], commit [6b052fb]

Summary: ❌

job_name test_name status info comment
Integration tests (amd_binary, 3/5) failure
test_storage_s3_queue/test_4.py::test_list_and_delete_race FAIL
Finish Workflow failure
python3 ./ci/jobs/scripts/workflow_hooks/new_tests_check.py failure

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Sep 4, 2025
@vitlibar vitlibar marked this pull request as ready for review September 4, 2025 11:24
@evillique evillique self-assigned this Sep 4, 2025
@vitlibar
Copy link
Copy Markdown
Member Author

vitlibar commented Sep 4, 2025

CI failures are unrelated:

@vitlibar vitlibar enabled auto-merge September 4, 2025 16:42
@vitlibar vitlibar added this pull request to the merge queue Sep 4, 2025
Merged via the queue into ClickHouse:master with commit 901b98d Sep 4, 2025
119 of 122 checks passed
@vitlibar vitlibar deleted the fix-shutdown-in-arrow-flight-handler branch September 4, 2025 16:57
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 4, 2025
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Sep 8, 2025
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Sep 8, 2025
@robot-ch-test-poll4
Merge pull request #86792 from ClickHouse/cherrypick/25.8/86665
7441800 
Cherry pick #86665 to 25.8: Fix shutdown of ArrowFlight handler
robot-clickhouse added a commit that referenced this pull request Sep 8, 2025
@robot-clickhouse
Backport #86665 to 25.8: Fix shutdown of ArrowFlight handler
217f8a7
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Sep 8, 2025
Merged
@robot-ch-test-poll2 robot-ch-test-poll2 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Sep 8, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 8, 2025
clickhouse-gh bot added a commit that referenced this pull request Sep 8, 2025
@clickhouse-gh
Merge pull request #86793 from ClickHouse/backport/25.8/86665
745a58c 
Backport #86665 to 25.8: Fix shutdown of ArrowFlight handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evillique evillique evillique approved these changes

Assignees

@evillique evillique

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v25.8-must-backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trivial crash with arrowflight

6 participants

@vitlibar @evillique @Algunenano @robot-ch-test-poll1 @robot-ch-test-poll2 @robot-clickhouse-ci-1