Added clickhouse-benchmark --precise for better per-interval statistics#86684
Merged
Added clickhouse-benchmark --precise for better per-interval statistics#86684
clickhouse-benchmark --precise for better per-interval statistics#86684Conversation
Contributor
clickhouse-gh
bot
added
the
pr-improvement
bharatnc
reviewed
Sep 4, 2025
Co-authored-by: Bharat Nallan <bharat@clickhouse.com>
bharatnc
reviewed
Sep 6, 2025
bharatnc
reviewed
Sep 6, 2025
bharatnc
approved these changes
Sep 6, 2025
Co-authored-by: Bharat Nallan <bharat@clickhouse.com>
Co-authored-by: Bharat Nallan <bharat@clickhouse.com>
Member
Author
|
The failed test |
…ouse into benchmark-precise-mode
robot-ch-test-poll4
added
the
pr-synced-to-cloud
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clickhouse-benchmarkreports QPS for every interval set by--delay SECONDSoption. Reported QPS values are unreliable when the number of queries per interval is not very high and queries intersect interval boundaries. This PR adds logic to mitigate this drawback by collecting stats simultaneously for multiple intervals. If the query starts in one interval and finishes in another, then such a query is accounted in all intervals with appropriate weights (see the long comment in code).Here is the example of a run (look at the QPS per interval)
Before: https://pastila.nl/?001e41ad/a96000574de1c429d9b3f4a9bcf8ac6c#kH/s+G/CeG6NvBsE6jhZ2Q==
After: https://pastila.nl/?000b5e9f/ccb920d4efd26ec473e7adc3371b3a8f#WFxDE3I45j742SgV9hCYhA==
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
You can use
clickhouse-benchmark --preciseflag for more precise reporting of QPS and other per-interval metrics. It helps to get consistent QPS in case if durations of queries are comparable to the reporting interval--delay D