Support alter table ... materialize statistics all#87197
Merged
hanfei1991 merged 2 commits intoClickHouse:masterfrom Sep 17, 2025
Merged
Support alter table ... materialize statistics all#87197hanfei1991 merged 2 commits intoClickHouse:masterfrom
hanfei1991 merged 2 commits intoClickHouse:masterfrom
Conversation
Contributor
|
Workflow [PR], commit [a377baa] Summary: ❌
|
alesapin
approved these changes
Sep 16, 2025
clickhouse-gh
bot
added
the
pr-improvement
Member
Author
|
flaky test #87183 |
Merged
via the queue into
ClickHouse:master
with commit Sep 17, 2025
9dba3c1
121 of 123 checks passed
robot-clickhouse-ci-2
added
the
pr-synced-to-cloud
CurtizJ
reviewed
Sep 30, 2025
Comment on lines
+436
to
449
| if (!ParserKeyword(Keyword::ALL).ignore(pos, expected)) | ||
| { | ||
| if (!parser_partition.parse(pos, command_partition, expected)) | ||
| if (s_if_exists.ignore(pos, expected)) | ||
| command->if_exists = true; | ||
|
|
||
| if (!parser_stat_decl_without_types.parse(pos, command_statistics_decl, expected)) | ||
| return false; | ||
|
|
||
| if (s_in_partition.ignore(pos, expected)) | ||
| { | ||
| if (!parser_partition.parse(pos, command_partition, expected)) | ||
| return false; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I think it makes sense to allow MATERIALIZE STATISTICS ALL IN PARTITION ... Now, it's not possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Support
alter table ... materialize statistics allwill materialize all the statistics of a tableDocumentation entry for user-facing changes