Skip to content

small fixes to cmake flags around object storage#87314

Merged
bharatnc merged 5 commits intomasterfrom
ncb/cmake-flags-storage
Sep 23, 2025
Merged

small fixes to cmake flags around object storage#87314
bharatnc merged 5 commits intomasterfrom
ncb/cmake-flags-storage

Conversation

@bharatnc
Copy link
Copy Markdown
Contributor

@bharatnc bharatnc commented Sep 19, 2025 •
edited by divanik
Loading

I should be able to use s3 without avro.
I should be able to use s3 without azure blob storage.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Sep 19, 2025 •
edited
Loading

Workflow [PR], commit [b5f72b9]

Summary: ❌

job_name test_name status info comment
Performance Comparison (amd_release, master_head, 2/3) error
Performance Comparison (amd_release, master_head, 3/3) error

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 19, 2025
@divanik divanik self-assigned this Sep 19, 2025
divanik
divanik reviewed Sep 19, 2025
View reviewed changes
Comment thread src/Storages/ObjectStorage/registerStorageObjectStorage.cpp Outdated
Comment thread src/Storages/ObjectStorage/registerStorageObjectStorage.cpp
@kssenii kssenii self-assigned this Sep 23, 2025
kssenii
kssenii reviewed Sep 23, 2025
View reviewed changes
Comment thread src/Storages/ObjectStorage/registerStorageObjectStorage.cpp Outdated
@bharatnc bharatnc enabled auto-merge September 23, 2025 14:27
@bharatnc
Copy link
Copy Markdown
Contributor Author

bharatnc commented Sep 23, 2025

Thank you both for the reviews. Hopefully, this would make it easier for me to locally build the binary with S3 only with minimal dependencies.

@bharatnc bharatnc added this pull request to the merge queue Sep 23, 2025
Merged via the queue into master with commit cc9da57 Sep 23, 2025
120 of 123 checks passed
@bharatnc bharatnc deleted the ncb/cmake-flags-storage branch September 23, 2025 20:19
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

+1 more reviewer

@divanik divanik divanik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kssenii kssenii

@divanik divanik

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bharatnc @kssenii @divanik @robot-ch-test-poll4