Merged
Conversation
Contributor
|
Workflow [PR], commit [cf6a9ee] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-improvement
CheSema
reviewed
Sep 23, 2025
src/Disks/ObjectStorages/MetadataStorageFromDiskTransactionOperations.cpp
Outdated
Show resolved
Hide resolved
CheSema
reviewed
Sep 23, 2025
| { | ||
| return fs::path(dir) / getRandomASCIIString(32); | ||
|
|
||
| std::optional<DiskObjectStorageMetadata> tryReadMetadataFile(const std::string & compatible_key_prefix, const std::string & path, const IDisk & disk) |
Member
There was a problem hiding this comment.
I do not like that we use here compatible_key_prefix.
We could remove this later after #87335
CheSema
reviewed
Sep 23, 2025
src/Disks/ObjectStorages/MetadataStorageFromDiskTransactionOperations.cpp
Outdated
Show resolved
Hide resolved
CheSema
approved these changes
Sep 23, 2025
Member
Author
|
CI unrelated - for some reason, mt transactions were enabled with a plain rewritable disk |
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
This patch fixes rollbacks of unlink/rename/removeRecursive/removeDirectory/etc operations and also hardlink counts in any possible workloads for metadata from disk transactions, and simplifies the interfaces to make them more generic so that they can be reused in other meta stores.