Skip to content

Add --connection support for clickhouse-benchmarks#87370

Merged
azat merged 2 commits intoClickHouse:masterfrom
azat:benchmark-connection
Sep 23, 2025
Merged

Add --connection support for clickhouse-benchmarks#87370
azat merged 2 commits intoClickHouse:masterfrom
azat:benchmark-connection

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Sep 21, 2025

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Support --connection in clickhouse-benchmarks. It is the same as supported by clickhouse-client, you can specify predefined connections in client config.xml/config.yaml under connections_credentials path, to avoid explicitly specifying user/password via command line arguments. Add support for --accept-invalid-certificate into clickhouse-benchmark.

Refs: #45715 (cc @kssenii )

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 21, 2025

Workflow [PR], commit [199ad13]

Summary:

job_name test_name status info comment
Stateless tests (amd_tsan, s3 storage, parallel) failure
01201_read_single_thread_in_order FAIL
Integration tests (amd_tsan, 6/6) failure
test_throttling/test.py::test_remote_read_throttling_reload FAIL

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Sep 21, 2025
@azat azat force-pushed the benchmark-connection branch 2 times, most recently from 0c7bb5b to 8bce99c Compare September 21, 2025 16:51
@bharatnc bharatnc self-assigned this Sep 22, 2025
Support --connection in clickhouse-benchmarks. It is the same as
supported by clickhouse-client, you can specify predefined connections
in client config.xml/config.yaml under connections_credentials path, to
avoid explicitly specifying user/password via command line arguments.
@azat azat force-pushed the benchmark-connection branch 2 times, most recently from 8997763 to 15f2b5e Compare September 22, 2025 12:30
@azat azat force-pushed the benchmark-connection branch from 15f2b5e to 199ad13 Compare September 22, 2025 13:53
@azat azat enabled auto-merge September 23, 2025 19:13
@azat azat added this pull request to the merge queue Sep 23, 2025
Merged via the queue into ClickHouse:master with commit 9d5e859 Sep 23, 2025
120 of 123 checks passed
@azat azat deleted the benchmark-connection branch September 23, 2025 19:26
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants