Merged
Conversation
Contributor
|
Workflow [PR], commit [363c923] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-improvement
Member
|
Can you add a test to show this? |
Member
Author
|
Yes, but it's complex :( |
Member
Author
|
It doesn't work with simplest test |
Member
Author
|
We need to update AWS SDK to use If-None-Match header |
clickhouse-gh
bot
added
the
submodule changed
Member
Author
|
I'll move sdk update to a separate PR |
Member
Author
|
Depends on #87569 |
alesapin
commented
Oct 1, 2025
| services: | ||
| minio1: | ||
| image: minio/minio:RELEASE.2024-07-31T05-46-26Z | ||
| image: minio/minio:RELEASE.2024-09-13T20-26-02Z |
Member
Author
There was a problem hiding this comment.
Proper support for If-None-Match
…use into enable_parallel_write
scanhex12
reviewed
Oct 6, 2025
tests/integration/test_storage_iceberg_no_spark/test_writes_multiple_threads.py
Show resolved
Hide resolved
tests/integration/test_storage_iceberg_no_spark/test_writes_multiple_threads.py
Show resolved
Hide resolved
scanhex12
approved these changes
Oct 8, 2025
| file_path=local_path, | ||
| ) | ||
|
|
||
| class S3Downloader: |
Member
There was a problem hiding this comment.
It would be nice to add such downloader in all other tests, but I'll do it by myself
robot-ch-test-poll4
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Now setting
max_insert_threadswill take effect on Iceberg tables.Documentation entry for user-facing changes