Skip to content

Add column descriptions in system.database_replicas#87625

Merged
vitlibar merged 1 commit intoClickHouse:masterfrom
k-morozov:database_replicas_add_description
Oct 15, 2025
Merged

Add column descriptions in system.database_replicas#87625
vitlibar merged 1 commit intoClickHouse:masterfrom
k-morozov:database_replicas_add_description

Conversation

@k-morozov
Copy link
Copy Markdown
Contributor

@k-morozov k-morozov commented Sep 25, 2025 •
edited by vitlibar
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@k-morozov k-morozov changed the title Add column descriptions in ыныеуьюdatabase_replicas Add column descriptions in system.database_replicas Sep 25, 2025
@k-morozov k-morozov mentioned this pull request Sep 25, 2025
Merged
1 task
@vitlibar vitlibar self-assigned this Sep 25, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Sep 25, 2025 •
edited
Loading

Workflow [PR], commit [25643bc]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel) failure
02919_skip_lots_of_parsing_errors FAIL
Killed by signal (in clickhouse-server.log or clickhouse-server.err.log) FAIL
Fatal messages (in clickhouse-server.log or clickhouse-server.err.log) FAIL
Integration tests (amd_asan, old analyzer, 1/6) failure
test_storage_delta/test.py::test_replicated_database_and_unavailable_s3[0] FAIL
test_storage_delta/test.py::test_replicated_database_and_unavailable_s3[1] FAIL
Integration tests (amd_binary, 1/5) failure
test_storage_delta/test.py::test_replicated_database_and_unavailable_s3[1] FAIL
test_storage_delta/test.py::test_replicated_database_and_unavailable_s3[0] FAIL
Integration tests (arm_binary, distributed plan, 1/4) failure
test_storage_delta/test.py::test_replicated_database_and_unavailable_s3[1] FAIL
test_storage_delta/test.py::test_replicated_database_and_unavailable_s3[0] FAIL
Integration tests (amd_tsan, 1/6) failure
test_storage_delta/test.py::test_replicated_database_and_unavailable_s3[1] FAIL
test_storage_delta/test.py::test_replicated_database_and_unavailable_s3[0] FAIL
Performance Comparison (amd_release, master_head, 2/3) failure
Check Results failure

@vitlibar vitlibar added can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements pr-not-for-changelog This PR should not be mentioned in the changelog and removed pr-improvement Pull request with some product improvements labels Sep 25, 2025
alexey-milovidov
alexey-milovidov reviewed Sep 26, 2025
View reviewed changes
Comment thread src/Storages/System/StorageSystemDatabaseReplicas.cpp
{"log_ptr", std::make_shared<DataTypeInt32>(), "Maximum entry number in the log of general activity that the replica copied to its execution queue, plus one."},
{"total_replicas", std::make_shared<DataTypeUInt32>(), "The total number of known replicas of this database."},
{"zookeeper_exception", std::make_shared<DataTypeString>(), "The last exception message, got if the error happened when fetching the info from ClickHouse Keeper."},
{"is_session_expired", std::make_shared<DataTypeUInt8>(), "The session with ClickHouse Keeper has expired. Basically the same as `is_readonly`."}};
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then do we need it?

Copy link
Copy Markdown
Member

@vitlibar vitlibar Sep 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean When do we need is_session_expired?

If the session is expired then fields max_log_ptr, log_ptr, total_replicas shown in table system.database_replicas are not relevant because they are read from Keeper.

@vitlibar
Copy link
Copy Markdown
Member

vitlibar commented Oct 15, 2025 •
edited
Loading

CI failures are unrelated:

@vitlibar vitlibar enabled auto-merge October 15, 2025 14:16
@vitlibar vitlibar added this pull request to the merge queue Oct 15, 2025
Merged via the queue into ClickHouse:master with commit 44cbdef Oct 15, 2025
463 of 480 checks passed
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 15, 2025
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Oct 15, 2025
Merged
robot-clickhouse added a commit that referenced this pull request Oct 15, 2025
@robot-clickhouse
Backport #87625 to 25.9: Add column descriptions in system.database_r…
212c6f8 
…eplicas
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Oct 15, 2025
Merged
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 15, 2025
vitlibar added a commit that referenced this pull request Oct 16, 2025
@vitlibar
Merge pull request #88590 from ClickHouse/backport/25.9/87625
1a4041a 
Backport #87625 to 25.9: Add column descriptions in system.database_replicas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov left review comments

@vitlibar vitlibar vitlibar approved these changes

Assignees

@vitlibar vitlibar

Labels

can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@k-morozov @vitlibar @alexey-milovidov @robot-ch-test-poll @robot-ch-test-poll2