Fix incorrect handling of timeout for executable dictionaries#87627
Merged
azat merged 3 commits intoClickHouse:masterfrom Sep 25, 2025
Merged
Fix incorrect handling of timeout for executable dictionaries#87627azat merged 3 commits intoClickHouse:masterfrom
azat merged 3 commits intoClickHouse:masterfrom
Conversation
Contributor
|
Workflow [PR], commit [9f347b7] Summary: ❌
|
clickhouse-gh
bot
added
the
pr-bugfix
azat
commented
Sep 25, 2025
Comment on lines
-258
to
-275
| def test_executable_input_slow_python(started_cluster): | ||
| skip_test_msan(node) | ||
| assert node.query_and_get_error( | ||
| "SELECT dictGet('executable_input_slow_python', 'result', toUInt64(1))" | ||
| ) | ||
| assert node.query_and_get_error( | ||
| "SELECT dictGet('executable_input_slow_pool_python', 'result', toUInt64(1))" | ||
| ) | ||
|
|
||
|
|
||
| def test_executable_implicit_input_slow_python(started_cluster): | ||
| skip_test_msan(node) | ||
| assert node.query_and_get_error( | ||
| "SELECT dictGet('executable_implicit_input_slow_python', 'result', toUInt64(1))" | ||
| ) | ||
| assert node.query_and_get_error( | ||
| "SELECT dictGet('executable_implicit_input_slow_pool_python', 'result', toUInt64(1))" | ||
| ) |
Member
Author
There was a problem hiding this comment.
These two are duplicates, there are the same functions in this file.
vdimir
approved these changes
Sep 25, 2025
Merged
via the queue into
ClickHouse:master
with commit Sep 25, 2025
86d3f97
121 of 124 checks passed
robot-ch-test-poll3
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix incorrect handling of
command_read_timeoutfor executable dictionariesCI: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=87563&sha=f43fe8e980ddb3355dedc608591f360c961e19c7&name_0=PR&name_1=Integration%20tests%20%28arm_binary%2C%20distributed%20plan%2C%203%2F4%29