Skip to content

Remove WTF in changelog.md#87645

Merged
nikitamikhaylov merged 1 commit intomasterfrom
kssenii-patch-18
Sep 25, 2025
Merged

Remove WTF in changelog.md#87645
nikitamikhaylov merged 1 commit intomasterfrom
kssenii-patch-18

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Sep 25, 2025

Fix Changelog Entries for Data Lake Features

Summary

This PR cleans up several placeholder entries in the CHANGELOG.md file by:

  1. Providing proper documentation for the Iceberg and DeltaLake custom disk configuration feature
  2. Correcting setting names for Iceberg data file limits from max_iceberg_data_file_rows/bytes to iceberg_insert_max_rows_in_data_file/iceberg_insert_max_bytes_in_data_file
  3. Removing placeholder markers (��WTF, fix this!) from the changelog entries

Changes

  • Updated description for custom disk configuration in Iceberg and DeltaLake tables to specify that it's controlled via the disk storage level setting
  • Fixed settings names for the Iceberg data file limits to match the actual implementation
  • Cleaned up placeholder text that was accidentally left in the changelog

Motivation

These changes ensure the changelog accurately reflects the implemented features and provides the correct setting names for users. The PR eliminates placeholder text that was not meant for public release.

Impact

No code changes are included in this PR - only documentation improvements in CHANGELOG.md to ensure users have accurate information about the features and their configuration options.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

  • Fixed descriptions in CHANGELOG.md for Iceberg and DeltaLake tables features:
    • Added clarification that custom disk configuration is supported via storage level setting disk
    • Corrected naming of Iceberg insertion settings to iceberg_insert_max_rows_in_data_file and iceberg_insert_max_bytes_in_data_file
    • Improved descriptions of Delta Lake and Iceberg file size limiting functionality

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Sep 25, 2025

Workflow [PR], commit [8b8faff]

Summary:

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 25, 2025
@nikitamikhaylov nikitamikhaylov self-assigned this Sep 25, 2025
@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Sep 25, 2025
Merged via the queue into master with commit 16b1ae1 Sep 25, 2025
124 checks passed
@nikitamikhaylov nikitamikhaylov deleted the kssenii-patch-18 branch September 25, 2025 20:43
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants