Skip to content

Fix incorrect setting assignment in JoinSettings::updatePlanSettings#87675

Merged
devcrafter merged 1 commit intomasterfrom
vdimir/fix_typo
Sep 29, 2025
Merged

Fix incorrect setting assignment in JoinSettings::updatePlanSettings#87675
devcrafter merged 1 commit intomasterfrom
vdimir/fix_typo

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Sep 26, 2025

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix incorrect handling of settings max_joined_block_size_rows and max_joined_block_size_bytes during query plan serialization with experimental make_distributed_plan

Discovered together with @devcrafter

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 26, 2025

Workflow [PR], commit [dfe49c1]

Summary:

job_name test_name status info comment
Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel) failure
01167_isolation_hermitage FAIL
Exception in test runner FAIL
Killed by signal (in clickhouse-server.log or clickhouse-server.err.log) FAIL
Fatal messages (in clickhouse-server.log or clickhouse-server.err.log) FAIL

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Sep 26, 2025
@devcrafter devcrafter self-assigned this Sep 26, 2025
@devcrafter devcrafter added this pull request to the merge queue Sep 29, 2025
Merged via the queue into master with commit bbc1c0a Sep 29, 2025
121 of 123 checks passed
@devcrafter devcrafter deleted the vdimir/fix_typo branch September 29, 2025 16:00
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants