Skip to content

Expose the set of [Zoo]Keeper hosts through server setting#87718

Merged
nikitamikhaylov merged 4 commits intomasterfrom
keeper-hosts-setting
Sep 30, 2025
Merged

Expose the set of [Zoo]Keeper hosts through server setting#87718
nikitamikhaylov merged 4 commits intomasterfrom
keeper-hosts-setting

Conversation

@nikitamikhaylov
Copy link
Copy Markdown
Member

@nikitamikhaylov nikitamikhaylov commented Sep 26, 2025

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Added a new setting keeper_hosts that exposes the list of [Zoo]Keeper hosts ClickHouse can connect to.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 26, 2025 •
edited
Loading

Workflow [PR], commit [f94a519]

Summary: ❌

job_name test_name status info comment
Integration tests (amd_binary, 3/5) failure
test_merge_tree_s3/test.py::test_merge_canceled_by_s3_errors[node-broken_s3_always_multi_part] FAIL
Integration tests (arm_binary, distributed plan, 3/4) failure
test_keeper_memory_soft_limit/test.py::test_soft_limit_create FAIL
Stress test (amd_msan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Sep 26, 2025
@george-larionov
Copy link
Copy Markdown
Member

george-larionov commented Sep 26, 2025

Any tests for this new setting?

@george-larionov george-larionov self-assigned this Sep 26, 2025
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Sep 27, 2025

Interesting, why all tests have failed?

alexey-milovidov
alexey-milovidov approved these changes Sep 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, LGTM :)
Only a small functional test (like smoke test) is needed.

george-larionov
george-larionov approved these changes Sep 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@george-larionov george-larionov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well :)

@nikitamikhaylov
Copy link
Copy Markdown
Member Author

nikitamikhaylov commented Sep 30, 2025

Stress test (amd_msan): #84186
Integration test (arm_binary): #87877

@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Sep 30, 2025
@nikitamikhaylov nikitamikhaylov added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Sep 30, 2025
Merged via the queue into master with commit 68eb005 Sep 30, 2025
119 of 123 checks passed
@nikitamikhaylov nikitamikhaylov deleted the keeper-hosts-setting branch September 30, 2025 16:10
This was referenced Sep 30, 2025
Closed
Closed
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Sep 30, 2025
@robot-clickhouse
Merge pull request #87933 from ClickHouse/cherrypick/25.9/87718
0805778 
Cherry pick #87718 to 25.9: Expose the set of [Zoo]Keeper hosts through server setting
robot-clickhouse added a commit that referenced this pull request Sep 30, 2025
@robot-clickhouse
Backport #87718 to 25.9: Expose the set of [Zoo]Keeper hosts through …
57cd09c 
…server setting
@robot-clickhouse robot-clickhouse mentioned this pull request Sep 30, 2025
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 30, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Sep 30, 2025
@rienath rienath mentioned this pull request Oct 1, 2025
Merged
1 task
nikitamikhaylov added a commit that referenced this pull request Oct 31, 2025
@nikitamikhaylov
Merge pull request #87934 from ClickHouse/backport/25.9/87718
08f4606 
Backport #87718 to 25.9: Expose the set of [Zoo]Keeper hosts through server setting
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@george-larionov george-larionov george-larionov approved these changes

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@george-larionov george-larionov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-improvement Pull request with some product improvements pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nikitamikhaylov @george-larionov @alexey-milovidov @robot-ch-test-poll1 @robot-ch-test-poll2 @robot-clickhouse-ci-2