Skip to content

Fix reading null map subcolumn from Variants that cannot be inside Nullable#87798

Merged
Avogar merged 4 commits intoClickHouse:masterfrom
Avogar:fix-variant-null-map-subcolumn
Oct 14, 2025
Merged

Fix reading null map subcolumn from Variants that cannot be inside Nullable#87798
Avogar merged 4 commits intoClickHouse:masterfrom
Avogar:fix-variant-null-map-subcolumn

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Sep 29, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix reading null map subcolumn from Variants that cannot be inside Nullable.

Closes #87710

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 29, 2025

Workflow [PR], commit [c4edcec]

Summary:

job_name test_name status info comment
Integration tests (amd_tsan, 4/6) failure
test_replicated_merge_tree_encryption_codec/test.py::test_same_keys FAIL
Integration tests (amd_tsan, 6/6) failure
test_throttling/test.py::test_remote_write_throttling_reload FAIL

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Sep 29, 2025
@rienath rienath self-assigned this Sep 29, 2025
Copy link
Copy Markdown
Member

@rienath rienath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Avogar I left one comment. Also, there's a failing test that is trying to extract .null from a variant without a Nullable inside, which is now illegal. Otherwise looks good!

@Avogar Avogar added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Oct 14, 2025
@Avogar Avogar added this pull request to the merge queue Oct 14, 2025
Merged via the queue into ClickHouse:master with commit 5db1543 Oct 14, 2025
120 of 123 checks passed
@Avogar Avogar deleted the fix-variant-null-map-subcolumn branch October 14, 2025 10:15
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 14, 2025
robot-clickhouse added a commit that referenced this pull request Oct 14, 2025
Cherry pick #87798 to 25.7: Fix reading null map subcolumn from Variants that cannot be inside Nullable
robot-clickhouse added a commit that referenced this pull request Oct 14, 2025
robot-clickhouse added a commit that referenced this pull request Oct 14, 2025
Cherry pick #87798 to 25.8: Fix reading null map subcolumn from Variants that cannot be inside Nullable
robot-clickhouse added a commit that referenced this pull request Oct 14, 2025
robot-clickhouse added a commit that referenced this pull request Oct 14, 2025
Cherry pick #87798 to 25.9: Fix reading null map subcolumn from Variants that cannot be inside Nullable
robot-clickhouse added a commit that referenced this pull request Oct 14, 2025
clickhouse-gh bot added a commit that referenced this pull request Oct 14, 2025
Backport #87798 to 25.7: Fix reading null map subcolumn from Variants that cannot be inside Nullable
@robot-ch-test-poll robot-ch-test-poll added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Oct 14, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 22, 2025
rienath added a commit that referenced this pull request Oct 23, 2025
Backport #87798 to 25.9: Fix reading null map subcolumn from Variants that cannot be inside Nullable
rienath added a commit that referenced this pull request Oct 23, 2025
Backport #87798 to 25.8: Fix reading null map subcolumn from Variants that cannot be inside Nullable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logical error: 'Bad cast from type DB::ColumnArray to DB::ColumnVector<char8_t>'

5 participants