Fix handling error when failing to drop the database completely on the cluster on the secondary node.#87802
Merged
tuanpach merged 2 commits intoClickHouse:masterfrom Oct 10, 2025
Conversation
Contributor
|
Workflow [PR], commit [8c2cc4c] Summary: ❌
|
e490984 to
d685a3d
Compare
d4d18c6 to
b71f7b8
Compare
Avogar
reviewed
Oct 1, 2025
b71f7b8 to
cc866b8
Compare
Avogar
approved these changes
Oct 1, 2025
- In DDLWorker, when the task is not finished, throw an ErrorCodes::UNFINISHED exception if the task is retriable to retry the task.
cc866b8 to
8c2cc4c
Compare
Merged
via the queue into
ClickHouse:master
with commit Oct 10, 2025
2246635
121 of 123 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix handling error when failing to drop the database completely on the cluster on the secondary node.
There are 2 problems in https://github.com/ClickHouse/support-escalation/issues/5792:
In DatabaseCatalog::detachDatabase, we don't handle the exception, which leads to:
The change in this PR:
Closes https://github.com/ClickHouse/support-escalation/issues/5792
Documentation entry for user-facing changes