Skip to content

Fix data corruption with expired column TTL and sparse serialization#88095

Merged
CurtizJ merged 2 commits intoClickHouse:masterfrom
CurtizJ:fix-corruption-with-ttl
Oct 6, 2025
Merged

Fix data corruption with expired column TTL and sparse serialization#88095
CurtizJ merged 2 commits intoClickHouse:masterfrom
CurtizJ:fix-corruption-with-ttl

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Oct 4, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fixed possible data corruption in MergeTree tables with set column TTL.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Oct 4, 2025

Workflow [PR], commit [e56cffc]

Summary:

job_name test_name status info comment
Stress test (amd_debug) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL
Stress test (amd_msan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Oct 4, 2025
@alexey-milovidov alexey-milovidov self-assigned this Oct 4, 2025
@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Oct 6, 2025

Stress tests: #84669.

@CurtizJ CurtizJ added this pull request to the merge queue Oct 6, 2025
Merged via the queue into ClickHouse:master with commit 0ac42fa Oct 6, 2025
120 of 123 checks passed
@CurtizJ CurtizJ deleted the fix-corruption-with-ttl branch October 6, 2025 12:25
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 6, 2025
@fm4v fm4v added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Oct 6, 2025
@Algunenano
Copy link
Copy Markdown
Member

Introduced in #77166. Affects 25.7+

robot-ch-test-poll1 added a commit that referenced this pull request Oct 6, 2025
Cherry pick #88095 to 25.7: Fix data corruption with expired column TTL and sparse serialization
robot-clickhouse added a commit that referenced this pull request Oct 6, 2025
robot-ch-test-poll1 added a commit that referenced this pull request Oct 6, 2025
Cherry pick #88095 to 25.8: Fix data corruption with expired column TTL and sparse serialization
robot-clickhouse added a commit that referenced this pull request Oct 6, 2025
robot-ch-test-poll1 added a commit that referenced this pull request Oct 6, 2025
Cherry pick #88095 to 25.9: Fix data corruption with expired column TTL and sparse serialization
robot-clickhouse added a commit that referenced this pull request Oct 6, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Oct 6, 2025
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 6, 2025
clickhouse-gh bot added a commit that referenced this pull request Oct 6, 2025
Backport #88095 to 25.8: Fix data corruption with expired column TTL and sparse serialization
CurtizJ added a commit that referenced this pull request Oct 6, 2025
Backport #88095 to 25.7: Fix data corruption with expired column TTL and sparse serialization
@rschu1ze
Copy link
Copy Markdown
Member

Users affected by this issue can fix the data corruption by running a repair tool on their broken parts: #88192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants