Skip to content

InlineAddedColumns::appendFromBlock#88455

Merged
nickitat merged 3 commits intomasterfrom
demo
Oct 16, 2025
Merged

InlineAddedColumns::appendFromBlock#88455
nickitat merged 3 commits intomasterfrom
demo

Conversation

@nickitat
Copy link
Copy Markdown
Member

@nickitat nickitat commented Oct 13, 2025 •
edited
Loading

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Inline AddedColumns::appendFromBlock for slightly better join performance in some cases.

Screenshot 2025-10-16 at 12 48 37

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Oct 13, 2025 •
edited
Loading

Workflow [PR], commit [dc9b8f8]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_debug, distributed plan, s3 storage, sequential) failure
01459_manual_write_to_replicas_quorum_detach_attach FAIL cidb
Stateless tests (arm_binary, sequential) failure
03141_fetches_errors_stress FAIL cidb

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 13, 2025
@yariks5s yariks5s self-assigned this Oct 13, 2025
@nickitat nickitat added pr-performance Pull request with some performance improvements and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Oct 15, 2025
@clickhouse-gh clickhouse-gh bot added pr-not-for-changelog This PR should not be mentioned in the changelog and removed pr-performance Pull request with some performance improvements labels Oct 15, 2025
@nickitat nickitat added pr-performance Pull request with some performance improvements and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Oct 15, 2025
@nickitat nickitat changed the title Small change in AddedColumns InlineAddedColumns::appendFromBlock Oct 16, 2025
@nickitat nickitat enabled auto-merge October 16, 2025 10:55
@nickitat nickitat added this pull request to the merge queue Oct 16, 2025
Merged via the queue into master with commit 9dea2ef Oct 16, 2025
952 of 956 checks passed
@nickitat nickitat deleted the demo branch October 16, 2025 11:11
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yariks5s yariks5s yariks5s approved these changes

Assignees

@yariks5s yariks5s

Labels

pr-performance Pull request with some performance improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nickitat @yariks5s @robot-ch-test-poll1 @rschu1ze