Conversation
Contributor
|
Workflow [PR], commit [db280c6] Summary: ❌
|
scanhex12
approved these changes
Oct 15, 2025
Member
scanhex12
left a comment
There was a problem hiding this comment.
LGTM, but please change label to "critical bugfix"
Member
Author
AFAIK even though this is a crash, as long as this is a bug in new functionality that hasn't been included in any release yet it's not considered a "bugfix" from changelog standpoint. |
Contributor
|
Hi @davenger @scanhex12 — while reviewing this PR I found the following:
Happy to discuss — close anything that's wrong or already addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #88569
The crash was caused by 1st argument of original
INfunction being reset to nullptr here:ClickHouse/src/Analyzer/Resolve/resolveFunction.cpp
Lines 390 to 395 in da741fb
Even though the function gets replaced in the query tree, in some case resolveFunction might be called again on a copy of the original FunctionNode pointer, e.g. in case when
INis inIFcondition:ClickHouse/src/Analyzer/Resolve/resolveFunction.cpp
Line 250 in da741fb
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes