Use correct max_binary_array_size setting for Array and Map binary deserialization#88744
Merged
Use correct max_binary_array_size setting for Array and Map binary deserialization#88744
max_binary_array_size setting for Array and Map binary deserialization#88744Conversation
Contributor
clickhouse-gh
bot
added
the
pr-improvement
Avogar
approved these changes
Oct 17, 2025
…ing array in binary [de]serialization
rienath
force-pushed
the
fix-rowbinary-serialization
branch
from
335751e to
44bd9b2
Compare
Member
Author
|
Integration tests (amd_binary, 5/5) Integration tests (amd_tsan, 1/6)
|
robot-ch-test-poll
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fixed binary deserialization of
ArrayandMapto use themax_binary_array_sizesetting instead ofmax_binary_string_sizewhen validating size limits. This ensures that the proper limits are applied when reading inRowBinaryformat.