Fix approx_top_k() to respect threshold parameter when called with si…#88867
Merged
yariks5s merged 1 commit intoClickHouse:masterfrom Oct 23, 2025
Merged
Fix approx_top_k() to respect threshold parameter when called with si…#88867yariks5s merged 1 commit intoClickHouse:masterfrom
yariks5s merged 1 commit intoClickHouse:masterfrom
Conversation
Contributor
Author
|
@UnamedRus Can you take a look at this PR? I think it's the exact change you described here. |
Contributor
|
Workflow [PR], commit [a70ebf9] Summary: ❌
|
yariks5s
approved these changes
Oct 22, 2025
Member
|
00900_long_parquet_load - #88893 Integration tests (amd_asan, old analyzer, 4/6) - flaky 03047_on_fly_mutations_non_deterministic_replace - flaky |
Merged
via the queue into
ClickHouse:master
with commit Oct 23, 2025
54d504a
119 of 123 checks passed
robot-ch-test-poll2
added a commit
that referenced
this pull request
Oct 27, 2025
Cherry pick #88867 to 25.10: Fix approx_top_k() to respect threshold parameter when called with si…
robot-clickhouse
added a commit
that referenced
this pull request
Oct 27, 2025
…ameter when called with si…
clickhouse-gh bot
added a commit
that referenced
this pull request
Oct 27, 2025
Backport #88867 to 25.10: Fix approx_top_k() to respect threshold parameter when called with si…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix
top_kto respect the threshold parameter when called with a single argument. Closes #88757Documentation entry for user-facing changes
Explaination
Previously this returned 30 rows now it returns 50 rows
Closes #88757