Fix missing dataset config in arrowflight when using a named collection#88868
Merged
alexey-milovidov merged 4 commits intoClickHouse:masterfrom Oct 24, 2025
Conversation
… is used. WIthout this, the dataset_name being passed to the flight server was blank.
Contributor
|
Workflow [PR], commit [099f273] Summary: ❌
|
Contributor
Author
|
There was an issue with gh cli failing to add a label. (cli/cli#11986) It somehow only affected my previous ci run, and seems to be working for other PRs submitted after mine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a named collection with the arrowFlight table function or table engine, clickhouse ignores the dataset config, and ends up passing and empty string to the flight enabled server.
IE
The above sends
dataset=''to that host.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
ArrowFlight endpoint sources that required an SSL connection (such as behind an AWS ALB) can now properly request a specific dataset.
Documentation entry for user-facing changes