Skip to content

Fix icebergS3Cluster reading with position deletes rows#88919

Merged
divanik merged 30 commits intoClickHouse:masterfrom
Ted-Jiang:git-1023
Nov 6, 2025
Merged

Fix icebergS3Cluster reading with position deletes rows#88919
divanik merged 30 commits intoClickHouse:masterfrom
Ted-Jiang:git-1023

Conversation

@Ted-Jiang
Copy link
Copy Markdown
Contributor

@Ted-Jiang Ted-Jiang commented Oct 23, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix icebergS3Cluster protocol. Started supporting schema evolution, positional and equality deletes in iceberg cluster function. Resolves #88287

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Details

Related issue: #88287
Closes: #88287

@Ted-Jiang
Copy link
Copy Markdown
Contributor Author

related issue #88287

@Ted-Jiang
Copy link
Copy Markdown
Contributor Author

@kssenii could you plz look at this pr or maybe ping someone related this ❤️

@Ted-Jiang
Copy link
Copy Markdown
Contributor Author

Another question is how to generate related test data like below.

SELECT * FROM icebergS3Cluster('test_cluster_two_shards_localhost', s3_conn, filename='est', SETTINGS iceberg_metadata_file_path = 'metadata/v2.metadata.json');

@kssenii
Copy link
Copy Markdown
Member

kssenii commented Oct 23, 2025

maybe ping someone related this

@divanik @scanhex12

@kssenii kssenii added the can be tested Allows running workflows for external contributors label Oct 23, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Oct 23, 2025

Workflow [PR], commit [5d01e48]

Summary:

job_name test_name status info comment
Integration tests (amd_asan, old analyzer, 4/6) failure
test_replicated_database_recover_digest_mismatch/test.py::test_recover_digest_mismatch FAIL cidb, flaky
Upgrade check (amd_tsan) failure
Killed by signal (in clickhouse-server.log) FAIL cidb
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL cidb
Killed by signal (output files) FAIL cidb
Found signal in gdb.log FAIL cidb

@Ted-Jiang Ted-Jiang closed this Oct 24, 2025
@Ted-Jiang Ted-Jiang reopened this Oct 24, 2025
@Ted-Jiang Ted-Jiang closed this Oct 24, 2025
@Ted-Jiang Ted-Jiang reopened this Oct 24, 2025
@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Oct 24, 2025
@Ted-Jiang Ted-Jiang closed this Oct 27, 2025
@Ted-Jiang Ted-Jiang reopened this Oct 27, 2025
@Ted-Jiang
Copy link
Copy Markdown
Contributor Author

@kssenii @alexey-milovidov Is there anything i can do to make this pr in progress?

@kssenii kssenii requested review from Avogar and removed request for Avogar October 28, 2025 10:39
@divanik
Copy link
Copy Markdown
Member

divanik commented Oct 28, 2025

Yes, that's a good fix, I wanted to do the same for last several weeks but was busy by other tasks

@divanik
Copy link
Copy Markdown
Member

divanik commented Oct 28, 2025

@Ted-Jiang, please, add an integration test. Do you know how to do it?

@divanik
Copy link
Copy Markdown
Member

divanik commented Nov 3, 2025

I did the last change (changed warning to info) because we trigger on warnings in our integration tests (I think this is a wrong behavior, but I don't want to deal with it now)

@divanik
Copy link
Copy Markdown
Member

divanik commented Nov 6, 2025

@divanik divanik added this pull request to the merge queue Nov 6, 2025
Merged via the queue into ClickHouse:master with commit d81ac0f Nov 6, 2025
122 of 125 checks passed
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 6, 2025
@divanik divanik added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Nov 6, 2025
@divanik
Copy link
Copy Markdown
Member

divanik commented Nov 6, 2025

@Ted-Jiang, thank you for your contribution! The ClickHouse community really appreciates it

@Ted-Jiang
Copy link
Copy Markdown
Contributor Author

@Ted-Jiang, thank you for your contribution! The ClickHouse community really appreciates it

@divanik Thanks for your helping, make this happen! 👍

robot-ch-test-poll1 added a commit that referenced this pull request Nov 7, 2025
Cherry pick #88919 to 25.10: Fix icebergS3Cluster reading with position deletes rows
robot-clickhouse added a commit that referenced this pull request Nov 7, 2025
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 7, 2025
divanik added a commit that referenced this pull request Nov 7, 2025
Backport #88919 to 25.10: Fix icebergS3Cluster reading with position deletes rows
divanik added a commit that referenced this pull request Dec 20, 2025
Cherry pick #88919 to 25.8: Fix icebergS3Cluster reading with position deletes rows
divanik added a commit that referenced this pull request Dec 20, 2025
Cherry pick #88919 to 25.9: Fix icebergS3Cluster reading with position deletes rows
@divanik divanik removed the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 29, 2025
robot-clickhouse added a commit that referenced this pull request Dec 29, 2025
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

icebergS3Cluster adds deleted rows

7 participants